Thumbnails are displayed when a guestbook is activated

[DS-INRAE]

• When does this issue occur?
  When a guestbook is configured on a dataset, the thumbnails are still visibles.

What steps does it take to reproduce the issue?
Create a dataset,
Add an image to create a thumbnail
Set a guestbook on the dataset
Log out and view the dataset page

• Which page(s) does it occurs on?
  Dataset page :
  
  File page :
  

• To whom does it occur (all users, curators, superusers)?
  all users

• What did you expect to happen?
  Thumbnails should behave the same as previews and be displayed only if the guestbook has been filled or if the user has viewing rights on the file

Which version of Dataverse are you using?
5.14

Any related open or closed issues to this bug report?

On thumbnails and restricted files :

• Thumbnail/preview shows as broken on restricted files #7859

On thumbnails code:

• [Spike - API] Create an endpoint to retrieve dataset thumbnails #10046
• Simplify thumbnail handling code and swap the image generation library #10515

Screenshots:

Screencast.from.2024-07-10.15-37-07.mp4

[pdurbin]

Interesting. This feels like a regression to me. I don't think we used to show thumbnails when a guestbook is enabled. It should be hidden, like it is for restricted files.

@DS-INRA if you happened to have tested this on https://demo.dataverse.org (6.2, currently) or https://beta.dataverse.org (develop branch) please let us know!

[DS-INRAE]

Thanks for the suggestion.
I have tested both beta and demo.
The behaviour is the same with demo:

https://demo.dataverse.org/dataset.xhtml?persistentId=doi%3A10.70122%2FFK2%2F8FKJT2
But the thumbnail is hidden on beta:
https://beta.dataverse.org/dataset.xhtml?persistentId=doi:10.5072/FK2/YJ6MTI

[jggautier]

#11283 feels related

[cmbz]

2025/03/03

• Requires more investigation to determine if the issue is a problem in the beta installation (that is not the SPA).
• Question: Is this the behavior that we want, or no?
  • @DS-INRAE @sbarbosadataverse @jggautier (re. checking with the Community about it?) could you weigh in please.

[cmbz]

2025-05-19

• @DS-INRAE could you please let us know if the beta behavior is what you want? Can we discuss briefly at DCM 2025 if needed? Thanks

[DS-INRAE]

@cmbz Yes, the beta behaviour is what is expected :)

[cmbz]

2025-06-23

• @sbarbosadataverse will reach out to the community for feedback

[qqmyers]

Possibly related to #11588 - the caching added to speed display in JSF (which probably needs to be added for SPA) means that permission checks aren't made after caching occurs, so if a file becomes restricted, it still gets displayed.

[datacuratorcsuc]

I have tested this behavior in our Test environment (version 6.4) , and I can confirm that the thumbnail is shown even when the user is not logged in and has not completed the guestbook.

[sbarbosadataverse]

requested more community feedback (Dataverse Google Group and Zulip)

Hey Community:

Dataverse needs additional feedback on
Thumbnails are displayed when a guestbook is activated

The issue was tagged as a "bug," but we don't have consensus on whether the community expects thumbnails and guestbooks to function as they are, or as described in this issue.

We could consider configurations at the installation level to resolve this request, if possible.

Do you consider the thumbnail display a bug?
Do you consider this to be expected behavior?
If you're experiencing a bug, what are potential solutions to allow your installation to use this feature as expected?

Please leave feedback by August 10th

Thanks much