From 952617e70d6937d0987161c4e47f4d6bf3e31cd4 Mon Sep 17 00:00:00 2001 From: Philip Durbin Date: Mon, 12 May 2025 15:09:00 -0400 Subject: [PATCH 1/4] enforce Java 17 (no higher) --- modules/dataverse-parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/dataverse-parent/pom.xml b/modules/dataverse-parent/pom.xml index da52497657c..7eb9fad4c87 100644 --- a/modules/dataverse-parent/pom.xml +++ b/modules/dataverse-parent/pom.xml @@ -362,7 +362,7 @@ - [${target.java.version}.0,) + [${target.java.version},18] From 28d288bd369e2d3c3974b82a0ccaa9e702e4bf1a Mon Sep 17 00:00:00 2001 From: Oliver Bertuch Date: Wed, 4 Jun 2025 13:48:10 +0200 Subject: [PATCH 2/4] Revert "enforce Java 17 (no higher)" This reverts commit 952617e70d6937d0987161c4e47f4d6bf3e31cd4. --- modules/dataverse-parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/dataverse-parent/pom.xml b/modules/dataverse-parent/pom.xml index 7eb9fad4c87..da52497657c 100644 --- a/modules/dataverse-parent/pom.xml +++ b/modules/dataverse-parent/pom.xml @@ -362,7 +362,7 @@ - [${target.java.version},18] + [${target.java.version}.0,) From 048c241aea0a73ec3ee9a1eb8996764fce29cf49 Mon Sep 17 00:00:00 2001 From: Oliver Bertuch Date: Wed, 4 Jun 2025 13:54:58 +0200 Subject: [PATCH 3/4] refactor(build): centralize `auto-service` version and configure annotation processor #11487 Before JDK 23, the annotation processor for Auto Service was picked up automatically. With newer JDKs, the META-INF/services files were not generated, which made it impossible for the PID Factories to be picked up by the ServiceLoader at runtime. Following the documentation, we seem to have missed adding the annotation processor to the Maven Build Plugin. Adding this missing bit re-enables the auto-generation on newer JDKs. See also: https://github.com/google/auto/blob/bb4d48e4ca0bda0e75b3b67f6ff4f464db9304e4/service/README.md --- pom.xml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2fed88cb473..2fe0eaa632c 100644 --- a/pom.xml +++ b/pom.xml @@ -28,6 +28,7 @@ 1.2.18.4 10.19.0 + 1.1.1 1.20.1 5.4.0 2.9.2 @@ -526,7 +527,7 @@ com.google.auto.service auto-service - 1.1.1 + ${auto-service.version} true jar @@ -831,6 +832,14 @@ ${target.java.version} ${compilerArgument} + + + + com.google.auto.service + auto-service + ${auto-service.version} + + From c27c57b93df8624402ad49f5a1f89da07dbd2243 Mon Sep 17 00:00:00 2001 From: Philip Durbin Date: Wed, 4 Jun 2025 09:44:58 -0400 Subject: [PATCH 4/4] recommend Java 17 because we test with it #11487 --- doc/sphinx-guides/source/developers/dev-environment.rst | 2 +- doc/sphinx-guides/source/installation/prerequisites.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/sphinx-guides/source/developers/dev-environment.rst b/doc/sphinx-guides/source/developers/dev-environment.rst index f0d1b116ea7..3f7222667df 100755 --- a/doc/sphinx-guides/source/developers/dev-environment.rst +++ b/doc/sphinx-guides/source/developers/dev-environment.rst @@ -30,7 +30,7 @@ Detailed Steps Install Java ~~~~~~~~~~~~ -The Dataverse Software requires Java 17. +The recommended version is Java 17 because it's the version we test with. See https://github.com/IQSS/dataverse/pull/9764. On Mac and Windows, we suggest using `SDKMAN `_ to install Temurin (Eclipe's name for its OpenJDK distribution). Type ``sdk install java 17`` and then hit the "tab" key until you get to a version that ends with ``-tem`` and then hit enter. diff --git a/doc/sphinx-guides/source/installation/prerequisites.rst b/doc/sphinx-guides/source/installation/prerequisites.rst index 1632515b13a..a5aacc4701c 100644 --- a/doc/sphinx-guides/source/installation/prerequisites.rst +++ b/doc/sphinx-guides/source/installation/prerequisites.rst @@ -19,7 +19,7 @@ We assume you plan to run your Dataverse installation on Linux and we recommend Java ---- -The Dataverse Software requires Java SE 17 (or higher). +The recommended version is Java 17 because it's the version we test with. Installing Java ===============