@qqmyers I made this change without testing anything because I wasn't sure how to. Can you please advise? I'd like to add something under "how to test" about it.

I guess you can unit test w.r.t. making sure the CSLJson output has the review type if your datasettype is review. Beyond that, the CSL Json is used in front side JavaScript to generate any of thousands of citation formats, but any given format may or may not use CSLType in generating its output. I can't think of any easy way to test that (but that would really be testing the CSL Java and JavaScript libraries - if our code gets the CSLType into the CSL Json output here, things should work).

Ok, thanks. Do you know of any format that uses CSLType? Maybe we can test that type by manually inspecting its output?

I don't know. AI says APA for the social sciences and Chicago for history and arts, and MLA for humanities are popular for reviews - hopefully that means they check the type.

Ok, I'm still confused. Still not sure how to test this from JSF. I did look at APA and it says [dataset] (not [review] ) like this:

But I'm not sure if I'm looking in the right place.

If you think I should simply back out of this change, I'm ok with that. Less to mention in the release note. 😄

You can get the CSL format itself via api, e.g. curl https://demo.dataverse.org/api/datasets/:persistentId/versions/1.0/citation/CSL?persistentId=doi:10.70122/FK2/GJF7SF - note the native api guide appears to have an error and lists the format as "CSLJson" rather than "CSL".

Thanks, at https://dev1.dataverse.org/api/datasets/:persistentId/versions/1.0/citation/CSL?persistentId=doi%3A10.5072/FK2/RMEZNL I'm getting this:

{
    "id": "-GEN-2mqfdnmq0r",
    "type": "dataset",
    "categories": [
    ],
    "author": [
        {
            "family": "Simpson",
            "given": "Homer",
            "isInstitution": false
        }
    ],
    "issued": {
        "date-parts": [
            [
                2025
            ]
        ]
    },
    "DOI": "10.5072/FK2/RMEZNL",
    "publisher": "Root",
    "title": "Review of Darwin's Finches",
    "URL": "http://ec2-44-214-43-137.compute-1.amazonaws.com/citation?persistentId=doi:10.5072/FK2/RMEZNL",
    "version": "V1"
}

(I need to fix my siteUrl, obviously.) 😅

I guess you're saying ideally "type" would be "review" or at least not "dataset" in that output. It makes me wonder what my change did, if anything. 🤔

Also, thanks for the heads up about the typo in the guides.

I meant to say you've given me an API endpoint to dig into. Thanks!

Shouldn't this say ("Dataset", "Software", "Workflow", "Other")? Review is sent to Datacite as "Other"

Hmm, good point. Maybe I'll change this to "certain types" and link to the table I made elsewhere, or something. Thanks! 😅