Merge pull request #81 from ISISComputingGroup/77

Tom-Willemsen · web-flow · commit a2f2886f05c0 · 2024-11-27T15:51:12.000Z
fix hidden pv toggle
diff --git a/app/components/Block.test.tsx b/app/components/Block.test.tsx
@@ -31,7 +31,7 @@ it("renders topbar unchanged", () => {
 it("renders nothing if pv is hidden", () => {
   const aBlock: IfcBlock = { pvaddress: "SOME:PV", visible: false };
   const { container } = render(
-    <Block pv={aBlock} instName={""} showHiddenBlocks={false} />,
+    <Block pv={aBlock} instName={"ANINST"} showHiddenBlocks={false} />,
     {
       container: tableBody,
     },
diff --git a/app/components/Block.tsx b/app/components/Block.tsx
@@ -18,7 +18,7 @@ export default function Block({
     string | number | undefined
   >();
   const [showAdvanced, setShowAdvanced] = useState(false);
-  if (!pv.visible && !showHiddenBlocks && !instName) {
+  if (!pv.visible && !showHiddenBlocks) {
     return null;
   }
   if (pv.value != currentValue) {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ it("renders topbar unchanged", () => {`
`31`	`31`	`it("renders nothing if pv is hidden", () => {`
`32`	`32`	`const aBlock: IfcBlock = { pvaddress: "SOME:PV", visible: false };`
`33`	`33`	`const { container } = render(`
`34`		`- <Block pv={aBlock} instName={""} showHiddenBlocks={false} />,`
	`34`	`+ <Block pv={aBlock} instName={"ANINST"} showHiddenBlocks={false} />,`
`35`	`35`	`{`
`36`	`36`	`container: tableBody,`
`37`	`37`	`},`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ export default function Block({`
`18`	`18`	`string \| number \| undefined`
`19`	`19`	`>();`
`20`	`20`	`const [showAdvanced, setShowAdvanced] = useState(false);`
`21`		`- if (!pv.visible && !showHiddenBlocks && !instName) {`
	`21`	`+ if (!pv.visible && !showHiddenBlocks) {`
`22`	`22`	`return null;`
`23`	`23`	`}`
`24`	`24`	`if (pv.value != currentValue) {`