Fix astroid warnings

Author: Tom-Willemsen

src/genie_python/genie_api_setup.py

@@ -284,8 +284,8 @@ def __init__(self, original_function: Callable) -> None:
     def just_path_on_load(self, text: str, act_tok: Any) -> list[str]:
         """
         Returns completions for load on a path if load_script in path otherwise returns as before.
-        Will replace .metadata\.plugins\org.eclipse.pde.core\.bundle_pool\plugins\
-        org.python.pydev_5.9.2.201708151115\pysrc\_pydev_bundle\pydev_ipython_console_011.py
+        Will replace .metadata\\.plugins\\org.eclipse.pde.core\\.bundle_pool\\plugins\\
+        org.python.pydev_5.9.2.201708151115\\pysrc\\_pydev_bundle\\pydev_ipython_console_011.py
 
         This functions will filter out the pydev completions if the line contains load_script. 
         It know which are the pydev ones because they are marked with the type '11'.

src/genie_python/scanning_instrument_pylint_plugin.py

@@ -1,7 +1,7 @@
 from typing import TYPE_CHECKING, Any
 
-import astroid
 from astroid import MANAGER
+from astroid.nodes import Arguments, ClassDef, FunctionDef, Module
 
 if TYPE_CHECKING:
     from pylint.lint import PyLinter
@@ -11,7 +11,7 @@ def register(linter: "PyLinter") -> None:
     """Register the plugin."""
 
 
-def transform(node: astroid.ClassDef, *args: Any, **kwargs: Any) -> None:
+def transform(node: ClassDef, *args: Any, **kwargs: Any) -> None:
     """Add ScanningInstrument methods to the declaring module.
 
     If the given class is derived from ScanningInstrument,
@@ -22,16 +22,16 @@ def transform(node: astroid.ClassDef, *args: Any, **kwargs: Any) -> None:
     if node.basenames and "ScanningInstrument" in node.basenames:
         public_methods = filter(lambda method: not method.name.startswith("__"), node.methods())
         for public_method in public_methods:
-            if isinstance(node.parent, astroid.Module):
-                new_func = astroid.FunctionDef(
+            if isinstance(node.parent, Module):
+                new_func = FunctionDef(
                     name=public_method.name,
                     lineno=0,
                     col_offset=0,
                     parent=node.parent,
                     end_lineno=0,
                     end_col_offset=0,
                 )
-                arguments = astroid.Arguments(
+                arguments = Arguments(
                     vararg=None,
                     kwarg=None,
                     parent=new_func,
@@ -50,4 +50,4 @@ def transform(node: astroid.ClassDef, *args: Any, **kwargs: Any) -> None:
                 node.parent.locals[public_method.name] = [new_func]
 
 
-MANAGER.register_transform(astroid.ClassDef, transform)
+MANAGER.register_transform(ClassDef, transform)

tests/test_script_checker.py

@@ -24,7 +24,7 @@
 import tempfile
 import unittest
 
-import astroid
+from astroid.nodes import Module
 
 from genie_python.genie_epics_api import API
 from genie_python.genie_script_checker import ScriptChecker
@@ -405,17 +405,17 @@ def test_GIVEN_builtin_module_THEN_it_can_safely_be_cached(self):
     def test_GIVEN_site_packages_module_THEN_it_can_safely_be_cached(self):
         import numpy
 
-        mod = astroid.Module(numpy.__name__, numpy.__file__)
+        mod = Module(numpy.__name__, numpy.__file__)
         self.assertTrue(self.checker._can_cache_module("numpy", mod))
 
     def test_GIVEN_user_script_THEN_it_should_not_be_cached(self):
         name = "my_user_script"
-        mod = astroid.Module(name, os.path.join("C:\\", "scripts", "my_user_script.py"))
+        mod = Module(name, os.path.join("C:\\", "scripts", "my_user_script.py"))
         self.assertFalse(self.checker._can_cache_module(name, mod))
 
     def test_GIVEN_instrument_script_THEN_it_should_not_be_cached(self):
         name = "my_inst_script"
-        mod = astroid.Module(
+        mod = Module(
             name,
             os.path.join(
                 "C:\\",