Merge pull request #278 from aaron-long/get_submodules_add_exception_for_import_submodules

Extended exception logic to get_submodules on import_module

Author: DominicOram

requirements-dev.txt

@@ -7,8 +7,8 @@ sphinx_rtd_theme
 semantic_version
 PyYAML
 scanf>=1.4.1
-pytest
+pytest>=3.6
 pytest-cov
 coverage
-flake8
+flake8==3.5.0
 tox

setup.py

@@ -59,8 +59,8 @@ def readme():
 
     extras_require={
         'epics': ['pcaspy'],
-        'dev': ['flake8', 'mock>=1.0.1', 'sphinx>=1.4.5', 'sphinx_rtd_theme',
-                'pytest', 'pytest-cov', 'coverage', 'tox'],
+        'dev': ['flake8==3.5.0', 'mock>=1.0.1', 'sphinx>=1.4.5', 'sphinx_rtd_theme',
+                'pytest>=3.6', 'pytest-cov', 'coverage', 'tox'],
     },
 
     entry_points={

src/lewis/core/utils.py

@@ -37,8 +37,10 @@
 
 from .exceptions import LewisException, LimitViolationException
 from lewis import __version__
+from lewis.core.logging import has_log
 
 
+@has_log
 def get_submodules(module):
     """
     This function imports all sub-modules of the supplied module and returns a dictionary
@@ -65,10 +67,11 @@ def get_submodules(module):
                 try:
                     submodules[module_name] = importlib.import_module(
                         '.{}'.format(module_name), package=module.__name__)
-                except ImportError:
+                except ImportError as import_error:
                     # This is necessary in case random directories are in the path or things can
                     # just not be imported due to other ImportErrors.
-                    pass
+                    get_submodules.log.error("ImportError for {module}: {error}"
+                                             .format(module=module_name, error=import_error))
 
     return submodules