Skip to content

Don't allow control-server thread to try to join itself #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rerpha merged 2 commits into from
Mar 18, 2025
Merged

Don't allow control-server thread to try to join itself #326

rerpha merged 2 commits into from
Mar 18, 2025

Conversation

@Tom-Willemsen
Copy link
Member

@Tom-Willemsen Tom-Willemsen commented Mar 16, 2025 •
edited
Loading

Closes #322

To test:

  • Run example on ticket
  • Run an IOC test that uses lewis backdoor, ensure it still works

@Tom-Willemsen Tom-Willemsen marked this pull request as ready for review March 16, 2025 12:28
@Tom-Willemsen Tom-Willemsen moved this to Flash Review in Tasks Mar 16, 2025
@rerpha rerpha self-requested a review March 18, 2025 14:07
@rerpha rerpha merged commit 1ce985d into main Mar 18, 2025
15 checks passed
@rerpha rerpha deleted the lewis_322 branch March 18, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rerpha rerpha rerpha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Tasks
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simulation stop raises RuntimeError "Cannot join current thread".

3 participants

@Tom-Willemsen @rerpha