add log file arg back, use logger for sniff

Author: rerpha

src/saluki/main.py

@@ -22,6 +22,14 @@ def main() -> None:
         prog="saluki",
         description="serialise/de-serialise flatbuffers and consume/produce from/to kafka",
     )
+    parser.add_argument(
+        "-l",
+        "--log-file",
+        help="filename to output all data to",
+        required=False,
+        default=None,
+        type=argparse.FileType("a"),
+    )
 
     topic_parser = argparse.ArgumentParser(add_help=False)
     topic_parser.add_argument("topic", type=str, help="Kafka topic. format is broker<:port>/topic")
@@ -95,6 +103,9 @@ def main() -> None:
         sys.exit(1)
     args = parser.parse_args()
 
+    if args.log_file:
+        logger.addHandler(logging.FileHandler(args.log_file.name))
+
     if "kafka_config" in args and args.kafka_config is not None:
         raise NotImplementedError("-X is not implemented yet.")
 

src/saluki/sniff.py

@@ -1,21 +1,25 @@
+import logging
+
 from confluent_kafka import Consumer, TopicPartition
 from confluent_kafka.admin import AdminClient
 
+logger = logging.getLogger("saluki")
+
 
 def sniff(broker: str) -> None:
     a = AdminClient({"bootstrap.servers": broker})
     c = Consumer({"bootstrap.servers": broker, "group.id": "saluki-sniff"})
     t = a.list_topics(timeout=5)
-    print(f"Cluster ID: {t.cluster_id}")
-    print("Brokers:")
-    [print(f"\t{value}") for value in t.brokers.values()]
+    logger.info(f"Cluster ID: {t.cluster_id}")
+    logger.info("Brokers:")
+    [logger.info(f"\t{value}") for value in t.brokers.values()]
 
-    print("Topics:")
+    logger.info("Topics:")
 
     for k, v in t.topics.items():
         partitions = v.partitions.keys()
-        print(f"\t{k}:")
+        logger.info(f"\t{k}:")
         for p in partitions:
             tp = TopicPartition(k, p)
             low, high = c.get_watermark_offsets(tp)
-            print(f"\t\tlow:{low}, high:{high}, num_messages:{high - low}")
+            logger.info(f"\t\tlow:{low}, high:{high}, num_messages:{high - low}")