pyright fixes

Author: rerpha

src/saluki/play.py

@@ -45,13 +45,15 @@ def play(
                 TopicPartition(src_topic, src_partition, timestamps[1]),
             ]
         )
-    else:
+    elif offsets is not None:
         start_offset = TopicPartition(src_topic, src_partition, offsets[0])
         stop_offset = TopicPartition(src_topic, src_partition, offsets[1])
+    else:
+        raise ValueError("offsets and timestamps cannot both be None")
+
     consumer.assign([start_offset])
 
     num_messages = stop_offset.offset - start_offset.offset + 1
-    msgs = []
 
     try:
         msgs = consumer.consume(num_messages)

tests/test_play.py

@@ -1,5 +1,6 @@
 from unittest.mock import Mock, patch
 
+import pytest
 from confluent_kafka import Message, TopicPartition
 
 from saluki.play import play
@@ -95,3 +96,8 @@ def test_play_with_exception_when_consuming_consumer_still_closed():
         mock_logger.exception.assert_called_once()
 
         mock_consumer().close.assert_called_once()
+
+
+def test_play_raises_when_offsets_and_timestamps_are_none():
+    with pytest.raises(ValueError):
+        play("", "", "", "", None, None)

tests/test_sniff.py

@@ -13,8 +13,8 @@ def test_sniff_with_two_partitions_in_a_topic():
     ):
         fake_cluster_md = ClusterMetadata()
         broker1 = BrokerMetadata()
-        broker1.id = "id1"
-        broker1.host = "mybroker"
+        broker1.id = "id1"  # type: ignore
+        broker1.host = "mybroker"  # type: ignore
         broker1.port = 9093
         fake_cluster_md.brokers = {0: broker1}
 

tests/test_utils.py

@@ -79,7 +79,7 @@ def test_deserialising_message_which_raises_does_not_stop_loop(mock_message):
 def test_deserialising_with_schema_list_ignores_messages_with_schema_not_in_list(mock_message):
     with patch("saluki.utils.logger") as logger:
         ok_message = Mock(spec=Message)
-        ok_message.value.return_value = serialise_fc00(config_change=1, streams=[])
+        ok_message.value.return_value = serialise_fc00(config_change=1, streams=[])  # type: ignore
         ok_message.error.return_value = False
         ok_message.timestamp.return_value = 2, 1