Skip to content

Commit 64deef2

Browse files
authored
Merge pull request #762 from IT-Academy-BCN/feature#761-close-filters-modal
fix(starter): enable Escape and backdrop close on challenge filters modal
2 parents 52403ed + 778c290 commit 64deef2

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
44
and this project adheres to
55
[Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
### [ita-challenges-frontend-3.27.2-RELEASE] - 2026-02-23
8+
9+
### Fixed
10+
- Enabled closing the Challenge Filters modal via `Escape` key and backdrop click. GitHub [#761], PR [#762].
11+
712
### [ita-challenges-frontend-3.27.1-RELEASE] - 2026-02-21
813

914
### Fixed

conf/.env.CI.dev

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
MICROSERVICE_DEPLOY=ita-challenges-frontend
2-
MICROSERVICE_VERSION=3.27.1-RELEASE
2+
MICROSERVICE_VERSION=3.27.2-RELEASE

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ita-challenges-frontend",
3-
"version": "3.27.1-RELEASE",
3+
"version": "3.27.2-RELEASE",
44
"scripts": {
55
"ng": "ng",
66
"start": "ng serve --proxy-config proxy.conf.dev.json",

src/app/modules/starter/components/challenge-filters-trigger/challenge-filters-trigger.component.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ describe('ChallengeFiltersTriggerComponent', () => {
131131
expect(callArgs[1]).toEqual(
132132
jasmine.objectContaining({
133133
windowClass: 'challenge-filters-trigger-modal',
134-
backdrop: 'static',
135-
keyboard: false
134+
backdrop: true,
135+
keyboard: true
136136
})
137137
)
138138
})

src/app/modules/starter/components/challenge-filters-trigger/challenge-filters-trigger.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ export class ChallengeFiltersTriggerComponent {
6767

6868
this.modalService.open(this.modalTemplate, {
6969
windowClass: 'challenge-filters-trigger-modal',
70-
backdrop: 'static',
71-
keyboard: false
70+
backdrop: true,
71+
keyboard: true
7272
})
7373

7474
setTimeout(() => {

0 commit comments

Comments
 (0)