Skip to content

Commit ecbc28f

Browse files
authored
Merge pull request #777 from IT-Academy-BCN/feature/231-style-tag-chips-from-filters-treigger
PR 2/2 - feat(challenge-filters): add styles to the tags on the filters trigger component
2 parents 16b6039 + d818f4c commit ecbc28f

File tree

7 files changed

+25
-12
lines changed

7 files changed

+25
-12
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
44
and this project adheres to
55
[Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
### [ita-challenges-frontend-3.34.0-RELEASE] - 2026-03-07
8+
9+
### Added
10+
- Applied styles to the `challengeFiltersTriggerComponent` tags
11+
712
### [itachallenge-challenge-3.33.0-RELEASE] - 2026-02-22
813

914
### Added

conf/.env.CI.dev

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
MICROSERVICE_DEPLOY=ita-challenges-frontend
2-
MICROSERVICE_VERSION=3.33.0-RELEASE
2+
MICROSERVICE_VERSION=3.34.0-RELEASE

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ita-challenges-frontend",
3-
"version": "3.33.0-RELEASE",
3+
"version": "3.34.0-RELEASE",
44
"scripts": {
55
"ng": "ng",
66
"start": "ng serve --proxy-config proxy.conf.dev.json",

src/app/modules/starter/components/challenge-filters-trigger/challenge-filters-trigger.component.html

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -86,18 +86,23 @@
8686
<legend class="h6 m-0 fw-bold">{{ 'modules.starter.challengeFiltersTrigger.tagsTitle' | translate }}</legend>
8787
<div class="d-flex gap-2"></div>
8888

89-
<div *ngFor="let group of displayTags">
90-
<strong>{{ group.language }}</strong>
89+
<div *ngIf="displayTags.length === 0">
90+
{{ 'modules.starter.challengeFiltersTrigger.noTagsFound' | translate }}
91+
</div>
92+
93+
<div class="d-flex flex-column gap-1" *ngFor="let group of displayTags">
94+
<span>{{ group.language }}</span>
9195
<div class="d-flex flex-wrap gap-2 mt-1 mb-2">
92-
<label *ngFor="let tag of group.tags" class="form-check">
93-
<input
94-
type="checkbox"
95-
class="form-check-input"
96-
[checked]="isTagSelected(tag.id_tag)"
97-
(change)="toggleTag(tag.id_tag)"
98-
/>
96+
<button
97+
*ngFor="let tag of group.tags"
98+
type="button"
99+
class="btn rounded-pill"
100+
[attr.aria-pressed]="isTagSelected(tag.id_tag)"
101+
[ngClass]="isTagSelected(tag.id_tag) ? 'btn-dark' : 'btn-outline-dark'"
102+
(click)="toggleTag(tag.id_tag)"
103+
>
99104
{{ tag.tag_name }}
100-
</label>
105+
</button>
101106
</div>
102107
</div>
103108
</fieldset>

src/assets/i18n/ca.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@
146146
"closeAriaLabel": "Tancar",
147147
"difficultyTitle": "Dificultat",
148148
"tagsTitle": "Etiquetes",
149+
"noTagsFound": "No s'han trobat etiquetes, seleccioneu almenys un llenguatge",
149150
"searchTagsPlaceholder": "Cercar etiquetes",
150151
"statusTitle": "Estat",
151152
"statusNotStarted": "Nous",

src/assets/i18n/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@
146146
"closeAriaLabel": "Close",
147147
"difficultyTitle": "Difficulty",
148148
"tagsTitle": "Tags",
149+
"noTagsFound": "No tags found, please select at least one language first",
149150
"searchTagsPlaceholder": "Search tags",
150151
"statusTitle": "Status",
151152
"statusNotStarted": "New",

src/assets/i18n/es.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@
146146
"closeAriaLabel": "Cerrar",
147147
"difficultyTitle": "Dificultad",
148148
"tagsTitle": "Tags",
149+
"noTagsFound": "No se han encontrado tags, seleccione al menos un lenguaje",
149150
"searchTagsPlaceholder": "Buscar tags",
150151
"statusTitle": "Estado",
151152
"statusNotStarted": "Nuevos",

0 commit comments

Comments
 (0)