Donor flow when we don't have educators (#467)

* Donor flow when we don't have educators

* fix tests

Author: darkotodoric

src/Controller/Donor/RequestController.php

@@ -110,10 +110,16 @@ public function options(Request $request): Response
                 ]);
 
                 if (!$haveWaitingTransactions) {
-                    $this->createTransactionService->create($user, $userDonor->getAmount(), $userDonor->getSchoolType());
-                }
+                    $isCreated = $this->createTransactionService->create($user, $userDonor->getAmount(), $userDonor->getSchoolType());
+
+                    if ($isCreated) {
+                        $this->addFlash('success', 'Kreirane su ti instrukcije za uplatu, ostalo je samo da ih uplatiš i potvrdiš uplatu.');
 
-                return $this->redirectToRoute('donor_transaction_list');
+                        return $this->redirectToRoute('donor_transaction_list');
+                    }
+
+                    $this->addFlash('info', 'Trenutno nema nastavnika kojima je potrebno uplatiti novac. Čim bude bilo potrebe biće ti napravljene instrukcije za uplatu i dobićeš obaveštenje na email.');
+                }
             }
 
             $this->addFlash('success', 'Uspesno ste promenili podatke');

src/Controller/Donor/TransactionController.php

@@ -198,10 +198,14 @@ public function create(Request $request)
             $amount = $form->get('amount')->getData();
             $schoolType = $form->get('schoolType')->getData();
 
-            $this->createTransactionService->create($user, $amount, $schoolType);
-            $this->addFlash('success', 'Kreirane su ti instrukcije za uplatu, ostalo je samo da ih uplatiš i potvrdiš uplatu.');
+            $isCreated = $this->createTransactionService->create($user, $amount, $schoolType);
+            if ($isCreated) {
+                $this->addFlash('success', 'Kreirane su ti instrukcije za uplatu, ostalo je samo da ih uplatiš i potvrdiš uplatu.');
 
-            return $this->redirectToRoute('donor_transaction_list');
+                return $this->redirectToRoute('donor_transaction_list');
+            }
+
+            $this->addFlash('info', 'Trenutno nema nastavnika kojima je potrebno uplatiti novac. Pokušaj kasnije kada se prijave novi nastavnici.');
         }
 
         return $this->render('donor/transaction/create.html.twig', [

templates/flashes.html.twig

@@ -21,6 +21,13 @@
             </div>
         {% endfor %}
 
+        {% for message in app.flashes('info') %}
+            <div role="alert" class="alert alert-info alert-soft mb-2">
+                <span class="ti ti-exclamation-circle text-2xl"></span>
+                <span>{{ message }}</span>
+            </div>
+        {% endfor %}
+
         {% for email in app.flashes('unverified_user') %}
             <div role="alert" class="alert alert-warning mb-2">
                 <span class="ti ti-exclamation-circle text-2xl"></span>

tests/Controller/Donor/RequestControllerTest.php

@@ -176,17 +176,13 @@ public function testNewUserSubscribeAndRegistrationAndVerification(): void
         // Submit form
         $this->client->submit($form);
 
-        $this->client->followRedirect();
         $this->assertResponseIsSuccessful();
 
         // Check are user donor saved
         $userDonor = $this->userDonorRepository->findOneBy(['user' => $user]);
         $this->assertEquals(10000, $userDonor->getAmount());
         $this->assertEquals(UserDonor::SCHOOL_TYPE_ALL, $userDonor->getSchoolType());
 
-        // Check are user redirected to right page
-        $this->assertStringContainsString('/instrukcije-za-uplatu', $this->client->getRequest()->getUri());
-
         // Try to unsubscribe
         $this->client->request('GET', '/mesecna-donacija');
         $crawler = new Crawler($this->client->getResponse()->getContent());
@@ -278,12 +274,6 @@ public function testNewUserOnetimeAndRegistrationAndVerification(): void
         // Submit form
         $this->client->submit($form);
 
-        $this->client->followRedirect();
-        $this->assertResponseIsSuccessful();
-
-        // Check are user redirected to right page
-        $this->assertStringContainsString('/instrukcije-za-uplatu', $this->client->getRequest()->getUri());
-
         $userDonor = $this->userDonorRepository->findOneBy(['user' => $user]);
         $this->assertNull($userDonor);
     }