Skip to content

Commit 7f57aa0

Browse files
author
Denys Zaiats
committed
[master] - remove JS executing script of auto scrolling
1 parent 8f80bac commit 7f57aa0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/main/java/net/itarray/automotion/internal/ResponsiveUIChunkValidatorBase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,19 @@ public class ResponsiveUIChunkValidatorBase extends ResponsiveUIValidatorBase im
2222

2323
public ResponsiveUIChunkValidatorBase(UISnapshot snapshot, List<WebElement> webElements) {
2424
super(snapshot);
25-
rootElements = asElements(webElements);
2625
if (webElements.isEmpty()) {
2726
String message = "Set root web element";
2827
addError(message);
2928
} else {
3029
if (!getDriver().isAppiumContext()) {
3130
try {
3231
((JavascriptExecutor) getDriver().getDriver()).executeScript("arguments[0].scrollIntoView();", webElements.get(0));
33-
((JavascriptExecutor) getDriver().getDriver()).executeScript("javascript:window.scrollBy(0,250);");
32+
//((JavascriptExecutor) getDriver().getDriver()).executeScript("javascript:window.scrollBy(0,250);");
3433
((JavascriptExecutor) getDriver().getDriver()).executeScript("document.documentElement.style.overflow = 'hidden'");
3534
} catch (Exception e) {}
3635
}
3736
}
37+
rootElements = asElements(webElements);
3838
}
3939

4040
@Override

src/main/java/net/itarray/automotion/internal/UIValidatorBase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@ public class UIValidatorBase extends ResponsiveUIValidatorBase implements UIElem
3535

3636
public UIValidatorBase(UISnapshot snapshot, WebElement webElement, String readableNameOfElement) {
3737
super(snapshot);
38-
this.rootElement = asElement(webElement, readableNameOfElement);
3938
if (!getDriver().isAppiumContext()) {
4039
try {
4140
((JavascriptExecutor) getDriver().getDriver()).executeScript("arguments[0].scrollIntoView();", webElement);
42-
((JavascriptExecutor) getDriver().getDriver()).executeScript("javascript:window.scrollBy(0,250);");
41+
//((JavascriptExecutor) getDriver().getDriver()).executeScript("javascript:window.scrollBy(0,250);");
4342
((JavascriptExecutor) getDriver().getDriver()).executeScript("document.documentElement.style.overflow = 'hidden'");
4443
} catch (Exception e) {}
4544
}
45+
this.rootElement = asElement(webElement, readableNameOfElement);
4646
}
4747

4848
@Override

0 commit comments

Comments
 (0)