Skip to content

Commit bbf5cc9

Browse files
author
Denys Zaiats
committed
[master] - fixed scale factor and top offset
1 parent fad3af0 commit bbf5cc9

File tree

3 files changed

+32
-6
lines changed

3 files changed

+32
-6
lines changed

src/main/java/net/itarray/automotion/internal/ResponsiveUIValidatorBase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ private double getScaleFactor() {
124124
}
125125

126126
private int getYOffset() {
127-
if (isMobile() && getDriver().isAppiumWebContext() && getReport().isMobileTopBarOffset()) {
127+
if (isMobile() && getDriver().isAppiumWebContext() && getReport().isMobileTopBarOffsetState()) {
128128
if (isIOS() || isAndroid()) {
129-
return 20 * (int) getScaleFactor();
129+
return (int) getReport().getMobileTopBarOffsetState();
130130
}
131131
}
132132
return 0;

src/main/java/net/itarray/automotion/validation/ResponsiveUIValidator.java

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ public class ResponsiveUIValidator {
2121
private final List<String> jsonFiles = new ArrayList<>();
2222
private net.itarray.automotion.validation.Units units = net.itarray.automotion.validation.Units.PX;
2323

24-
private boolean mobileTopBarOffset = false;
24+
private boolean mobileTopBarOffsetState = false;
25+
private double mobileTopBarOffset = 20;
2526
private final DrawingConfiguration drawingConfiguration = new DrawingConfiguration();
2627
private double scaleFactor = 1;
2728

@@ -138,7 +139,18 @@ public ResponsiveUIValidator changeMetricsUnitsTo(util.validator.ResponsiveUIVal
138139
* @param state
139140
*/
140141
public void setTopBarMobileOffset(boolean state) {
141-
mobileTopBarOffset = state;
142+
mobileTopBarOffsetState = state;
143+
}
144+
145+
/**
146+
* Set top bar mobile offset. Applicable only for native mobile testing
147+
*
148+
* @param state
149+
* @param offset
150+
*/
151+
public void setTopBarMobileOffset(boolean state, double offset) {
152+
mobileTopBarOffsetState = state;
153+
mobileTopBarOffset = offset;
142154
}
143155

144156
/**
@@ -158,7 +170,11 @@ public double getRetinaScaleFactor() {
158170
return scaleFactor;
159171
}
160172

161-
public boolean isMobileTopBarOffset() {
173+
public boolean isMobileTopBarOffsetState() {
174+
return mobileTopBarOffsetState;
175+
}
176+
177+
public double getMobileTopBarOffsetState() {
162178
return mobileTopBarOffset;
163179
}
164180

src/main/java/util/validator/ResponsiveUIValidator.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,16 @@ public void setTopBarMobileOffset(boolean state) {
8080
responsiveUIValidator.setTopBarMobileOffset(state);
8181
}
8282

83+
/**
84+
* Set top bar mobile offset. Applicable only for native mobile testing
85+
*
86+
* @param state
87+
* @param offset
88+
*/
89+
public void setTopBarMobileOffset(boolean state, double offset) {
90+
responsiveUIValidator.setTopBarMobileOffset(state, offset);
91+
}
92+
8393
/**
8494
* Set retina scale factor. Current usage only for native mobile
8595
*
@@ -90,7 +100,7 @@ public void setRetinaScaleFactor(double factor) {
90100
}
91101

92102
public boolean isMobileTopBarOffset() {
93-
return responsiveUIValidator.isMobileTopBarOffset();
103+
return responsiveUIValidator.isMobileTopBarOffsetState();
94104
}
95105

96106
/**

0 commit comments

Comments
 (0)