removed duplicated messages

Author: Torsten-Mumme

src/main/java/net/itarray/automotion/internal/ResponsiveUIChunkValidatorBase.java

@@ -375,7 +375,6 @@ private void validateSameWidth(List<UIElement> elements) {
             if (!element.hasSameWidthAs(elementToCompare, getContext())) {
                 errors.add(String.format("Element %s has different width than element %s.", element.getQuotedName(), elementToCompare.getQuotedName()));
                 errors.draw(element);
-                errors.add(String.format("Element %s has different width than element %s.", elementToCompare.getQuotedName(), element.getQuotedName()));
                 errors.draw(elementToCompare);
             }
         }
@@ -388,7 +387,6 @@ private void validateSameHeight(List<UIElement> elements) {
             if (!element.hasSameHeightAs(elementToCompare, getContext())) {
                 errors.add(String.format("Element %s has different height than element %s.", element.getQuotedName(), elementToCompare.getQuotedName()));
                 errors.draw(element);
-                errors.add(String.format("Element %s has different height than element %s.", elementToCompare.getQuotedName(), element.getQuotedName()));
                 errors.draw(elementToCompare);
             }
         }
@@ -399,10 +397,8 @@ private void validateSameSize(List<UIElement> elements) {
             UIElement element = elements.get(i);
             UIElement elementToCompare = elements.get(i + 1);
             if (!element.hasSameSizeAs(elementToCompare, getContext())) {
-                // todo: one error message + visual feedback
                 errors.add(String.format("Element %s has different size than element %s.", element.getQuotedName(), elementToCompare.getQuotedName()));
                 errors.draw(element);
-                errors.add(String.format("Element %s has different size than element %s.", elementToCompare.getQuotedName(), element.getQuotedName()));
                 errors.draw(elementToCompare);
             }
 
@@ -415,9 +411,8 @@ private void validateHaveDifferentSizes(List<UIElement> elements) {
             for (int secondIndex = firstIndex+1; secondIndex < elements.size(); secondIndex++) {
                 UIElement elementToCompare = elements.get(secondIndex);
                 if (element.hasSameSizeAs(elementToCompare, getContext())) {
-                    errors.add(String.format("Element #%d has same size. Element size is: [%s, %s]", (firstIndex + 1), element.getWidth(), element.getHeight()));
+                    errors.add(String.format("Element %s has same size than element %s.", element.getQuotedName(), elementToCompare.getQuotedName()));
                     errors.draw(element);
-                    errors.add(String.format("Element #%d has same size. Element size is: [%s, %s]", (secondIndex + 1), elementToCompare.getWidth(), elementToCompare.getHeight()));
                     errors.draw(elementToCompare);
                 }
             }
@@ -430,9 +425,8 @@ private void validateHaveDifferentWidths(List<UIElement> elements) {
             for (int secondIndex = firstIndex+1; secondIndex < elements.size(); secondIndex++) {
                 UIElement elementToCompare = elements.get(secondIndex);
                 if (element.hasSameWidthAs(elementToCompare, getContext())) {
-                    errors.add(String.format("Element #%d has same width. Element width is: [%s, %s]", (firstIndex + 1), element.getWidth(), element.getHeight()));
+                    errors.add(String.format("Element %s has same width than element %s.", element.getQuotedName(), elementToCompare.getQuotedName()));
                     errors.draw(element);
-                    errors.add(String.format("Element #%d has same width. Element width is: [%s, %s]", (secondIndex + 2), elementToCompare.getWidth(), elementToCompare.getHeight()));
                     errors.draw(elementToCompare);
                 }
             }
@@ -445,9 +439,8 @@ private void validateNotSameHeight(List<UIElement> elements) {
             for (int secondIndex = firstIndex+1; secondIndex < elements.size(); secondIndex++) {
                 UIElement elementToCompare = elements.get(secondIndex);
                 if (element.hasSameHeightAs(elementToCompare, getContext())) {
-                    errors.add(String.format("Element #%d has same height. Element height is: [%s, %s]", (firstIndex + 1), element.getWidth(), element.getHeight()));
+                    errors.add(String.format("Element %s has same height than element %s.", element.getQuotedName(), elementToCompare.getQuotedName()));
                     errors.draw(element);
-                    errors.add(String.format("Element #%d has same height. Element height is: [%s, %s]", (secondIndex + 2), elementToCompare.getWidth(), elementToCompare.getHeight()));
                     errors.draw(elementToCompare);
                 }
             }

src/test/java/net/itarray/automotion/tests/errors/ErrorMessagesRegressionTest.java

@@ -245,7 +245,7 @@ public void haveEqualWidthChunk() {
         createChunkValidator(createElement(100, 200, 505, 405)).haveEqualWidth();
         Errors errors = base.getErrors();
         assertThat(errors.getLastMessage())
-                .isEqualTo("Element #2:[(100,200) - 405x205] has different width than element #1:[(100,200) - 400x200].");
+                .isEqualTo("Element #1:[(100,200) - 400x200] has different width than element #2:[(100,200) - 405x205].");
     }
 
     @Test
@@ -269,7 +269,7 @@ public void haveEqualHeightChunk() {
         createChunkValidator(createElement(100, 200, 505, 405)).haveEqualHeight();
         Errors errors = base.getErrors();
         assertThat(errors.getLastMessage())
-                .isEqualTo("Element #2:[(100,200) - 405x205] has different height than element #1:[(100,200) - 400x200].");
+                .isEqualTo("Element #1:[(100,200) - 400x200] has different height than element #2:[(100,200) - 405x205].");
     }
 
     @Test
@@ -285,7 +285,7 @@ public void haveEqualSizeChunk() {
         createChunkValidator(createElement(100, 200, 505, 405)).haveEqualSize();
         Errors errors = base.getErrors();
         assertThat(errors.getLastMessage())
-                .isEqualTo("Element #2:[(100,200) - 405x205] has different size than element #1:[(100,200) - 400x200].");
+                .isEqualTo("Element #1:[(100,200) - 400x200] has different size than element #2:[(100,200) - 405x205].");
     }
 
     @Test