Skip to content

Commit 04037f6

Browse files
authored
Deploy metabase in makefile (#1096)
* Metabase: add makefile up targets CI calls up-<target> makefile target. Without these target CI will fail * #1061 * #1093 * Metabase: add missing docker stack deploy stmt * #1061 * #1093
1 parent a207430 commit 04037f6

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

services/metabase/Makefile

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
REPO_BASE_DIR := $(shell git rev-parse --show-toplevel)
22

3-
include ${REPO_BASE_DIR}/scripts/common.Makefile
43
include ${REPO_BASE_DIR}/scripts/common-services.Makefile
4+
# common-services.Makefile should be included first as common.Makefile
5+
#relies on STACK_NAME var which is defined in common-services.Makefile
6+
include ${REPO_BASE_DIR}/scripts/common.Makefile
57

68
.PHONY: up
7-
up: ${TEMP_COMPOSE} ## Deploys metabase stack
9+
up: ${TEMP_COMPOSE} prune-docker-stack-configs ## Deploys metabase stack
10+
@docker stack deploy --with-registry-auth --prune --compose-file ${TEMP_COMPOSE} ${STACK_NAME}
811

912
up-aws: up
1013

0 commit comments

Comments
 (0)