Fix longhorn configuration bugs

Extra: introduce longhorn pv vales for portainer

Author: YuryHrytsuk

charts/Makefile

@@ -49,7 +49,6 @@ helmfile-sync: .check-helmfile-installed helmfile.yaml ## Syncs the helmfile con
 		$(MAKE) -s .helmfile-local-post-install; \
 	fi
 
-
 .PHONY: configure-local-hosts
 configure-local-hosts: ## Adds local hosts entries for the machine
 	@echo "Adding $(MACHINE_FQDN) hosts to /etc/hosts ..."

charts/longhorn/values.yaml.gotmpl

@@ -1,6 +1,7 @@
-global:
-  nodeSelector:
-    ops: "true"
+global: {}
+  # uncomment once we have >1 ops nodes
+  # nodeSelector:
+  #  ops: "true"
 
 defaultSettings:
   replicaAutoBalance: best-effort
@@ -15,8 +16,13 @@ defaultSettings:
   deletingConfirmationFlag: false
 
 persistence:
+  # use only for non-critical ops workloads
+  # for critical workloads (e.g. database)
+  # use application replication (e.g. postgres HA operator)
+  defaultClass: false
+
   # https://longhorn.io/docs/1.8.1/best-practices/#io-performance
-  defaultDataLocality: least-effort
+  defaultDataLocality: best-effort
   defaultClassReplicaCount: 2
   defaultFsType: xfs
 

charts/portainer/values.s3-pv.yaml.gotmpl renamed to charts/portainer/values.longhorn-pv.yaml.gotmpl

@@ -1,4 +1,4 @@
 persistence:
   enabled: true
   size: "1Gi"
-  storageClass: "csi-s3"
+  storageClass: "longhorn"