Skip to content

Commit 42511b0

Browse files
mrnicegyu11kaiser
andauthored
🐛 Fix 302 Redirect bug in cadvisor prometheus (#184)
* Fix 302 Redirect bug in cadvisor traefik * remove accidental code commit --------- Co-authored-by: kaiser <[email protected]>
1 parent 750cfa6 commit 42511b0

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

services/monitoring/docker-compose.aws.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
version: "3.7"
22
services:
3-
prometheus-catchall:
3+
prometheuscatchall:
44
dns: 8.8.8.8
55
deploy:
66
placement:
@@ -11,7 +11,7 @@ services:
1111
memory: 24576M
1212
reservations:
1313
memory: 24576M
14-
prometheus-cadvisor:
14+
prometheuscadvisor:
1515
dns: 8.8.8.8
1616
deploy:
1717
placement:

services/monitoring/docker-compose.dalco.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ services:
1414
constraints:
1515
- node.labels.grafana==true
1616

17-
prometheus-catchall:
17+
prometheuscatchall:
1818
deploy:
1919
placement:
2020
constraints:
2121
- node.labels.prometheus==true
22-
prometheus-cadvisor:
22+
prometheuscadvisor:
2323
deploy:
2424
placement:
2525
constraints:
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
version: "3.7"
22
services:
3-
prometheus-catchall:
3+
prometheuscatchall:
44
deploy:
55
labels:
66
- traefik.http.routers.prometheus.tls.certresolver=myresolver
@@ -10,7 +10,7 @@ services:
1010
labels:
1111
- traefik.http.routers.grafana.tls.certresolver=myresolver
1212

13-
prometheus-cadvisor:
13+
prometheuscadvisor:
1414
deploy:
1515
labels:
1616
- traefik.http.routers.prometheus.tls.certresolver=myresolver

services/monitoring/docker-compose.letsencrypt.http.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
version: "3.7"
22
services:
3-
prometheus-catchall:
3+
prometheuscatchall:
44
deploy:
55
labels:
66
- traefik.http.routers.prometheus.tls.certresolver=lehttpchallenge
77
grafana:
88
deploy:
99
labels:
1010
- traefik.http.routers.grafana.tls.certresolver=lehttpchallenge
11-
prometheus-cadvisor:
11+
prometheuscadvisor:
1212
deploy:
1313
placement:
1414
constraints:

services/monitoring/docker-compose.master.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ services:
55
placement:
66
constraints:
77
- node.labels.grafana==true
8-
prometheus-catchall:
8+
prometheuscatchall:
99
deploy:
1010
placement:
1111
constraints:
1212
- node.labels.prometheus==true
13-
prometheus-cadvisor:
13+
prometheuscadvisor:
1414
deploy:
1515
placement:
1616
constraints:

services/monitoring/docker-compose.yml.j2

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ configs:
3535
smokeping_prober_config:
3636
file: ./smokeping_prober_config.yaml
3737
services:
38-
prometheus-catchall:
38+
prometheuscatchall:
3939
hostname: "{% raw %}{{.Service.Name}}{% endraw %}"
4040
image: prom/prometheus:v2.44.0
4141
volumes:
@@ -73,14 +73,14 @@ services:
7373
- traefik.http.routers.prometheuscatchall.tls=true
7474
- traefik.http.middlewares.prometheuscatchall_stripprefixregex.stripprefixregex.regex=^/prometheus
7575
- traefik.http.routers.prometheuscatchall.middlewares=ops_whitelist_ips@docker, ops_auth@docker, ops_gzip@docker, prometheuscatchall_stripprefixregex
76-
- prometheus-job=prometheus-catchall
76+
- prometheus-job=prometheuscatchall
7777
- prometheus-port=${MONITORING_PROMETHEUS_PORT}
7878
resources:
7979
limits:
8080
memory: 4096M
8181
reservations:
8282
memory: 4096M
83-
prometheus-cadvisor:
83+
prometheuscadvisor:
8484
hostname: "{% raw %}{{.Service.Name}}{% endraw %}"
8585
image: prom/prometheus:v2.44.0
8686
volumes:
@@ -98,7 +98,7 @@ services:
9898
- "--storage.tsdb.retention=30d"
9999
- "--web.console.libraries=/usr/share/prometheus/console_libraries"
100100
- "--web.console.templates=/usr/share/prometheus/consoles"
101-
- "--web.external-url=https://${MONITORING_DOMAIN}/prometheus-cadvisor/"
101+
- "--web.external-url=https://${MONITORING_DOMAIN}/prometheuscadvisor/"
102102
- "--web.route-prefix=/"
103103
- "--storage.tsdb.allow-overlapping-blocks" # via https://jessicagreben.medium.com/prometheus-fill-in-data-for-new-recording-rules-30a14ccb8467
104104
#- "--web.enable-admin-api" This allows messing with prometheus using its API from the CLI. Disabled for security reasons by default.
@@ -118,7 +118,7 @@ services:
118118
- traefik.http.routers.prometheuscadvisor.tls=true
119119
- traefik.http.middlewares.prometheuscadvisor_stripprefixregex.stripprefixregex.regex=^/prometheuscadvisor
120120
- traefik.http.routers.prometheuscadvisor.middlewares=ops_whitelist_ips@docker, ops_auth@docker, ops_gzip@docker, prometheuscadvisor_stripprefixregex
121-
- prometheus-job=prometheus-cadvisor
121+
- prometheus-job=prometheuscadvisor
122122
- prometheus-port=${MONITORING_PROMETHEUS_PORT}
123123
resources:
124124
limits:

0 commit comments

Comments
 (0)