Skip to content

Commit dd4d822

Browse files
authored
Fix: J2 issue in gitlab CI/CD - Attempt3 (#906)
* wip * Add csi-s3 and have portainer use it * Change request @Hrytsuk 1GB max portainer volume size * Fix wrong filename * Fix registry local deploy * Traefik local deployment fixes * Fix local deployment graylog provisioning * Fix j2, double venv * Add python version * Idempotency for admin-panels * Remove faulty command * Local deploy fixes * Clean Up Local Minio * Remove unused code * Update Minio * minorfix * Fix .venv --------- Co-authored-by: Dustin Kaiser <[email protected]>
1 parent 8b9fcd0 commit dd4d822

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

Makefile

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,6 @@ down-maintenance: ## Stop the maintenance mode
7171
fi \
7272
,)
7373

74-
.PHONY: venv
75-
venv: .venv ## Creates a python virtual environment with dev tools (pip, pylint, ...)
76-
.venv:
77-
@python3 -m venv .venv
78-
@.venv/bin/pip3 install --upgrade pip wheel setuptools
79-
@.venv/bin/pip3 install typer
80-
@echo "To activate the venv, execute 'source .venv/bin/activate'"
8174

8275
# Misc: info & clean
8376
.PHONY: info info-vars info-local

scripts/common.Makefile

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -221,13 +221,17 @@ clean-default: .check_clean ## Cleans all outputs
221221
fi
222222
223223
# Helpers -------------------------------------------------
224-
.venv:
224+
# Replace the existing .venv target with the following
225+
$(REPO_BASE_DIR)/.venv/bin/activate:
225226
# creating virtual environment with tooling (jinja, etc)
226-
@python3 -m venv .venv
227-
@.venv/bin/pip3 install --upgrade pip wheel setuptools
228-
@.venv/bin/pip3 install jinja2 j2cli[yaml] typer
229-
@echo "To activate the venv, execute 'source .venv/bin/activate'"
230-
227+
python3 -m venv $(REPO_BASE_DIR)/.venv
228+
$(REPO_BASE_DIR)/.venv/bin/pip3 install --upgrade pip wheel setuptools
229+
$(REPO_BASE_DIR)/.venv/bin/pip3 install jinja2 j2cli[yaml] typer
230+
@echo "To activate the venv, execute 'source $(REPO_BASE_DIR)/.venv/bin/activate'"
231+
PHONY: .venv
232+
.venv: $(REPO_BASE_DIR)/.venv/bin/activate ## Creates a python virtual environment with dev tools (pip, pylint, ...)
233+
.PHONY: venv
234+
venv: $(REPO_BASE_DIR)/.venv/bin/activate ## Creates a python virtual environment with dev tools (pip, pylint, ...)
231235
232236
# https://github.com/kolypto/j2cli?tab=readme-ov-file#customization
233237
ifeq ($(shell test -f j2cli_customization.py && echo -n yes),yes)

0 commit comments

Comments
 (0)