Skip to content

Commit ec3e6b0

Browse files
authored
Update Github PR Template (#1074)
* Update Github PR Template Ask for docker healthcheck, traefik healthcheck and replicas's count * Add more checks
1 parent 797f4c9 commit ec3e6b0

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,16 @@
1818
- [ ] Service has placement constraints or is global
1919
- [ ] Service is restartable
2020
- [ ] Service restart is zero-downtime
21+
- [ ] Service has >1 replicas in PROD
22+
- [ ] Service has docker heathlcheck enabled
2123
- [ ] Service is monitored (via prometheus and grafana)
2224
- [ ] Service is not bound to one specific node (e.g. via files or volumes)
2325
- [ ] Relevant OPS E2E Test are added
26+
27+
If exposed via traefik
2428
- [ ] Service's Public URL is included in maintenance mode
25-
- [ ] Service's Public URL is included in testing mode -->
29+
- [ ] Service's Public URL is included in testing mode
30+
- [ ] Service's has Traefik (Service Loadbalancer) Healthcheck enabled
31+
- [ ] Credentials page is updated
32+
- [ ] Url added to e2e test services (e2e test checking that URL can be accessed)
33+
-->

0 commit comments

Comments
 (0)