Skip to content

Commit f3796d2

Browse files
authored
Fix portainer makefile (#1131)
* Automatically configure registry in portainer Creates a single authneticated dockerhub registry that lets pulling private images (i.e. updating service's image (that is private) in portainer shall work now) * closes #1089 * Update * Imrpove wait for it installation * Fix portainer makefile wrong options #1125 * fix * spacing
1 parent 19d1412 commit f3796d2

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

services/portainer/Makefile

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,40 +15,38 @@ include ${REPO_BASE_DIR}/scripts/common.Makefile
1515
.PHONY: up ## Deploys portainer stack
1616
up: .init .env secrets ${TEMP_COMPOSE}
1717
@docker stack deploy --with-registry-auth --prune --compose-file ${TEMP_COMPOSE} ${STACK_NAME}
18-
@$(MAKE) --noprint configure-portainer-registry
18+
@$(MAKE) --no-print-directory configure-portainer-registry
1919

2020
.PHONY: up-local ## Deploys portainer stack for local deployment
2121
up-local: .init .env secrets ${TEMP_COMPOSE} ${TEMP_COMPOSE}-local
2222
@docker stack deploy --with-registry-auth --prune --compose-file ${TEMP_COMPOSE}-local ${STACK_NAME}
23-
@$(MAKE) --noprint configure-portainer-registry
23+
@$(MAKE) --no-print-directory configure-portainer-registry
2424

2525
.PHONY: up-dalco ## Deploys portainer stack for Dalco Cluster
2626
up-dalco: .init .env secrets ${TEMP_COMPOSE}-dalco
2727
@docker stack deploy --with-registry-auth --prune --compose-file ${TEMP_COMPOSE}-dalco ${STACK_NAME}
28-
@$(MAKE) --noprint configure-portainer-registry
28+
@$(MAKE) --no-print-directory configure-portainer-registry
2929

3030
.PHONY: up-aws ## Deploys portainer stack for AWS
3131
up-aws: .init .env secrets ${TEMP_COMPOSE}-aws
3232
@docker stack deploy --with-registry-auth --prune --compose-file ${TEMP_COMPOSE}-aws ${STACK_NAME}
33-
@$(MAKE) --noprint configure-portainer-registry
33+
@$(MAKE) --no-print-directory configure-portainer-registry
3434

3535
.PHONY: up-public ## Deploys portainer stack for public access Cluster
3636
up-public: up-dalco
3737

3838
.PHONY: up-master ## Deploys portainer stack for master Cluster
3939
up-master: .init .env secrets ${TEMP_COMPOSE}-master
4040
@docker stack deploy --with-registry-auth --prune --compose-file ${TEMP_COMPOSE}-master ${STACK_NAME}
41-
@$(MAKE) --noprint configure-portainer-registry
42-
41+
@$(MAKE) --no-print-directory configure-portainer-registry
4342

4443
.PHONY: configure-portainer-registry
4544
configure-portainer-registry: venv $(VENV_BIN)/python $(WAIT_FOR_IT) ## Add registry to Portainer
46-
@$(MAKE) --no-print install REQUIREMENTS_FILE=./scripts/requirements.txt
45+
@$(MAKE) --no-print-directory install REQUIREMENTS_FILE=./scripts/requirements.txt
4746
@set -o allexport; source $(REPO_CONFIG_LOCATION); set +o allexport; \
4847
$(WAIT_FOR_IT) http $$PORTAINER_URL --timeout=120s --interval=5s --expect-status-code 200 && \
4948
$(VENV_BIN)/python ./scripts/configure_portainer_registry.py
5049

51-
5250
# Helpers -------------------------------------------------
5351

5452
.PHONY: ${TEMP_COMPOSE}

0 commit comments

Comments
 (0)