Skip to content

Commit fd358c9

Browse files
committed
Update Github PR Template
Ask for docker healthcheck, traefik healthcheck and replicas's count
1 parent 797f4c9 commit fd358c9

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,11 @@
1818
- [ ] Service has placement constraints or is global
1919
- [ ] Service is restartable
2020
- [ ] Service restart is zero-downtime
21+
- [ ] Service has >1 replicas in PROD
22+
- [ ] Service has docker heathlcheck enabled
2123
- [ ] Service is monitored (via prometheus and grafana)
2224
- [ ] Service is not bound to one specific node (e.g. via files or volumes)
2325
- [ ] Relevant OPS E2E Test are added
2426
- [ ] Service's Public URL is included in maintenance mode
25-
- [ ] Service's Public URL is included in testing mode -->
27+
- [ ] Service's Public URL is included in testing mode
28+
- [ ] Service's has Traefik (Service Loadbalancer) Healthcheck enabled -->

0 commit comments

Comments
 (0)