Skip to content

Add sto-worker simcore service #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 3, 2025
Merged

Add sto-worker simcore service #1008

merged 4 commits into from
Apr 3, 2025

Conversation

@YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Apr 3, 2025 •
edited
Loading

What do these changes do?

Resource limits based on
image

Related issue/s

Related PR/s

Checklist

  • I tested and it works

New Service Introduction

  • Service has resource limits and reservations
  • Service has placement constraints or is global
  • Service is restartable
  • Service restart is zero-downtime
  • Service is monitored (via prometheus and grafana) -- by prometheus but no special actions taken for Grafana
  • Service is not bound to one specific node (e.g. via files or volumes)
  • Relevant OPS E2E Test are added --> not applicable
  • Service's Public URL is included in maintenance mode --> not applicable
  • Service's Public URL is included in testing mode --> not applicable

@YuryHrytsuk YuryHrytsuk requested a review from mrnicegyu11 as a code owner April 3, 2025 11:41
@YuryHrytsuk YuryHrytsuk requested review from GitHK, giancarloromeo, mrnicegyu11 and sanderegg and removed request for mrnicegyu11 April 3, 2025 11:42
@YuryHrytsuk YuryHrytsuk self-assigned this Apr 3, 2025
@YuryHrytsuk YuryHrytsuk added this to the The Awakening milestone Apr 3, 2025
GitHK
GitHK reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to have a chat with @sanderegg about this and then we'll be back at you

@mrnicegyu11
Copy link
Member

mrnicegyu11 commented Apr 3, 2025

lgtm

sanderegg
sanderegg approved these changes Apr 3, 2025
View reviewed changes
@YuryHrytsuk YuryHrytsuk requested a review from GitHK April 3, 2025 13:41
@YuryHrytsuk YuryHrytsuk force-pushed the introduce-sto-worker-simcore-service branch from ea63ad1 to bc68c92 Compare April 3, 2025 13:43
@YuryHrytsuk YuryHrytsuk merged commit 611900c into ITISFoundation:main Apr 3, 2025
3 checks passed
@YuryHrytsuk YuryHrytsuk deleted the introduce-sto-worker-simcore-service branch April 3, 2025 13:57
@YuryHrytsuk YuryHrytsuk mentioned this pull request Apr 4, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@YuryHrytsuk YuryHrytsuk

Labels

FAST

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

Add sto-worker configuration

4 participants

@YuryHrytsuk @mrnicegyu11 @GitHK @sanderegg