Skip to content

Add wb-auth simcore service #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2025
Merged

Add wb-auth simcore service #1146

merged 5 commits into from
Jul 25, 2025

Conversation

@YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Jul 23, 2025 •
edited
Loading

What do these changes do?

Add ops configuration for wb-auth (new) simcore service

Related issue/s

Related PR/s

Checklist

  • I tested and it works

New service introduction:

@YuryHrytsuk YuryHrytsuk added this to the Engage milestone Jul 23, 2025
@YuryHrytsuk YuryHrytsuk self-assigned this Jul 23, 2025
@YuryHrytsuk YuryHrytsuk requested a review from mrnicegyu11 as a code owner July 23, 2025 12:42
@YuryHrytsuk YuryHrytsuk requested a review from pcrespov July 23, 2025 12:45
@YuryHrytsuk
Copy link
Collaborator Author

YuryHrytsuk commented Jul 23, 2025 •
edited
Loading

@pcrespov wb-auth service is missing explicit default network reference in simcore repository. If we don't define it explicitly, this won't be there as soon as ops repo adds more networks (e.g. monitoring). default simcore network we use to let simcore services communicate with one another (be reachable)

See example https://github.com/ITISFoundation/osparc-simcore/blob/master/services/docker-compose.yml#L66C9-L66C16

mrnicegyu11
mrnicegyu11 approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@YuryHrytsuk
Copy link
Collaborator Author

YuryHrytsuk commented Jul 23, 2025

Blocked until discussed misc. monitoring issues

pcrespov
pcrespov approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

So i understand tracing is missing, right?

@YuryHrytsuk YuryHrytsuk mentioned this pull request Jul 23, 2025
Closed
2 tasks
@YuryHrytsuk YuryHrytsuk requested a review from sanderegg July 23, 2025 13:36
sanderegg
sanderegg approved these changes Jul 24, 2025
View reviewed changes
@YuryHrytsuk YuryHrytsuk mentioned this pull request Jul 24, 2025
Closed
YuryHrytsuk added a commit to YuryHrytsuk/osparc-ops-environments that referenced this pull request Jul 24, 2025
@YuryHrytsuk
Traefik: use wb-auth for platform user auth
6792608 
Since new service for user authentication was introduced. We shall use
it in platform user authentication middleware

* ITISFoundation/osparc-simcore#8130
* ITISFoundation#1146

* ITISFoundation#1145
@YuryHrytsuk YuryHrytsuk mentioned this pull request Jul 24, 2025
Merged
1 task
@YuryHrytsuk
Copy link
Collaborator Author

YuryHrytsuk commented Jul 25, 2025

Blocked by #1149

@YuryHrytsuk YuryHrytsuk mentioned this pull request Jul 25, 2025
Closed
@YuryHrytsuk YuryHrytsuk merged commit 220efa6 into ITISFoundation:main Jul 25, 2025
3 checks passed
YuryHrytsuk added a commit that referenced this pull request Jul 25, 2025
@YuryHrytsuk
Traefik: use wb-auth for platform user auth (#1148)
e4bd11b 
Since new service for user authentication was introduced. We shall use
it in platform user authentication middleware

* ITISFoundation/osparc-simcore#8130
* #1146

* #1145
@YuryHrytsuk YuryHrytsuk deleted the add-simcore-wb-auth-service branch July 25, 2025 09:50
@YuryHrytsuk YuryHrytsuk mentioned this pull request Aug 8, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

Assignees

@YuryHrytsuk YuryHrytsuk

Labels

blocked / paused FAST

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

Add ops configuration for webserver auth service

4 participants

@YuryHrytsuk @mrnicegyu11 @pcrespov @sanderegg