🐛 (#118)

* update workflow before publishing python package

* fix dependency issue and bump version

* point to website in project description

* fix broken dependency

* improve doc

* add github token to download artifacts

* ensure only read-access @wvangeit

* yet another attempt at downloading artifacts

* make sure to use repo that ran the trigger wf

* another attempt at fixing

* change owner

* allow publishing to testpypi also when pr

* minor change

* revert minor (but breaking) change

* minor fix

* add debug messages

* another debug message

* hopefully the final version

* final fix

* minor fix

* move master and tag to individual jobs

* add debug messages

* dev->post

* add python script for determining semantic version

* minor changes

* minor changes

* improve error handling and add version file to artifacts

* check if release

* minor fix

* ensure to enter venv

* also when tagging

* source venv in publishin workflow

* ensure only master

* add script for testing 'pure' semver

* adapt workflows to new python script

* minor change

* attempt to evaluate expressions correctly

* several fixes to fix tests

* ensure repo is checked out in publish workflow

* several small fixes

* cleanup

* debug

* minor cleanup

* mionr changes

* add debug message

* minor change

* minor change

* yet another try

* minor change

* minor change

* minor change

* mionr change

* minor changes

* correct workflow run id

* cosmetic change

* avoid using gh

Author: bisgaard-itis

.github/workflows/build-python-client.yml

@@ -133,5 +133,3 @@ jobs:
     if: github.event_name == 'push' && ( startsWith(github.ref, 'refs/tags') || github.ref == 'refs/heads/master' )
     needs: [test-20-04, test-latest]
     uses: ./.github/workflows/publish-python-client.yml
-    with:
-      run_id: ${{github.run_id}}

.github/workflows/publish-python-client.yml

@@ -1,10 +1,6 @@
 name: publish-python-client
 on:
   workflow_call:
-    inputs:
-      run_id:
-        required: true
-        type: string
 permissions: read-all
 
 jobs:
@@ -29,16 +25,16 @@ jobs:
         run: |
           make devenv
       - name: Download wheels
-        id: download
+        uses: actions/download-artifact@v3
+        with:
+          name: osparc_python_wheels
+          path: osparc_python_wheels/
+      - name: Check release
+        id: release
         run: |
-          source .venv/bin/activate
-          repo=${{github.repository}}
-          gh run download ${{ inputs.run_id }} --repo=${repo}
           version=$(cat osparc_python_wheels/VERSION)
           is_release=$(python scripts/is_semantic_version.py "${version}" --no-raise-result)
           echo "is-release=${is_release}" >> $GITHUB_OUTPUT
-        env:
-          GH_TOKEN: ${{ github.token }}
       - name: Remove osparc wheel
         run: |
           osparc_wheel=$(ls osparc_python_wheels/osparc-*)
@@ -51,7 +47,7 @@ jobs:
           verbose: true
           packages-dir: osparc_python_wheels/
       - name: Publish osparc_client to PyPI
-        if: steps.download.outputs.is-release == 'True'
+        if: steps.release.outputs.is-release == 'True'
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           verbose: true
@@ -77,16 +73,16 @@ jobs:
         run: |
           make devenv
       - name: Download wheels
-        id: download
+        uses: actions/download-artifact@v3
+        with:
+          name: osparc_python_wheels
+          path: osparc_python_wheels/
+      - name: Check release
+        id: release
         run: |
-          source .venv/bin/activate
-          repo=${{github.repository}}
-          gh run download ${{ inputs.run_id }} --repo=${repo}
           version=$(cat osparc_python_wheels/VERSION)
           is_release=$(python scripts/is_semantic_version.py "${version}" --no-raise-result)
           echo "is-release=${is_release}" >> $GITHUB_OUTPUT
-        env:
-          GH_TOKEN: ${{ github.token }}
       - name: Remove osparc_client wheel
         run: |
           osparc_client_wheel=$(ls osparc_python_wheels/osparc_client*)
@@ -99,7 +95,7 @@ jobs:
           verbose: true
           packages-dir: osparc_python_wheels/
       - name: Publish osparc to PyPI
-        if: steps.download.outputs.is-release == 'True'
+        if: steps.release.outputs.is-release == 'True'
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           verbose: true