Skip to content

Commit 3bb0670

Browse files
committed
fix searchfile bug and filter tests for old clients
1 parent 7939666 commit 3bb0670

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

clients/python/src/osparc/_api_files_api.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,11 +251,15 @@ def _search_files(
251251
sha256_checksum: Optional[str] = None,
252252
timeout_seconds: int = DEFAULT_TIMEOUT_SECONDS,
253253
) -> PaginationGenerator:
254+
kwargs = {
255+
"file_id": file_id,
256+
"sha256_checksum": sha256_checksum,
257+
"timeout_seconds": timeout_seconds,
258+
}
259+
254260
def _pagination_method():
255261
return super(FilesApi, self).search_files_page(
256-
file_id=file_id,
257-
sha256_checksum=sha256_checksum,
258-
_request_timeout=timeout_seconds,
262+
{k: v for k, v in kwargs.items() if v is not None}
259263
)
260264

261265
return PaginationGenerator(

clients/python/test/e2e/test_files_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def max_diff(data: List[int]) -> int:
9999
files_api.delete_file(uploaded_file1.id)
100100

101101

102-
@skip_if_osparc_version(at_least=Version("0.8.0"))
102+
@skip_if_osparc_version(at_least=Version("0.8.3.post0.dev20"))
103103
@pytest.mark.parametrize("use_checksum", [True, False])
104104
@pytest.mark.parametrize("use_id", [True, False])
105105
def test_search_files(

0 commit comments

Comments
 (0)