minor improvements

Author: bisgaard-itis

clients/python/src/osparc/_api_files_api.py

@@ -101,11 +101,13 @@ async def download_file_async(
             url = urljoin(
                 self.api_client.configuration.host, f"/v0/files/{file_id}/content"
             )
-            with open(downloaded_file, mode="wb") as f:
-                async for chunk in session.stream(
-                    "GET", url=url, auth=self._auth, follow_redirects=True
-                ):
-                    f.write(chunk)
+            async for response in await session.stream(
+                "GET", url=url, auth=self._auth, follow_redirects=True
+            ):
+                response.raise_for_status()
+                with open(downloaded_file, mode="wb") as f:
+                    async for chunk in response.aiter_bytes():
+                        f.write(chunk)
         return str(downloaded_file.resolve())
 
     def upload_file(

clients/python/src/osparc/_http_client.py

@@ -88,7 +88,7 @@ async def _():
 
     async def _stream(
         self, method: Literal["GET"], url: str, *args, **kwargs
-    ) -> AsyncGenerator[bytes, None]:
+    ) -> AsyncGenerator[httpx.Response, None]:
         n_attempts = self.configuration.retries.total
         assert isinstance(n_attempts, int)
 
@@ -98,17 +98,15 @@ async def _stream(
             stop=tenacity.stop_after_attempt(n_attempts),
             retry=tenacity.retry_if_exception_type(httpx.HTTPStatusError),
         )
-        async def _() -> AsyncGenerator[bytes, None]:
+        async def _() -> AsyncGenerator[httpx.Response, None]:
             async with self._client.stream(
                 method=method, url=url, *args, **kwargs
             ) as response:
                 if response.status_code in self.configuration.retries.status_forcelist:
                     response.raise_for_status()
-                async for chunk in response.aiter_bytes():
-                    yield chunk
+                yield response
 
-        async for chunk in _():
-            yield chunk
+        return _()
 
     async def put(self, *args, **kwargs) -> httpx.Response:
         return await self._request(self._client.put, *args, **kwargs)
@@ -127,9 +125,8 @@ async def get(self, *args, **kwargs) -> httpx.Response:
 
     async def stream(
         self, method: Literal["GET"], url: str, *args, **kwargs
-    ) -> AsyncGenerator[bytes, None]:
-        async for chunk in self._stream(method=method, url=url, *args, **kwargs):
-            yield chunk
+    ) -> AsyncGenerator[httpx.Response, None]:
+        return await self._stream(method=method, url=url, *args, **kwargs)
 
     def _wait_callback(self, retry_state: tenacity.RetryCallState) -> int:
         assert retry_state.outcome is not None