🗑️ Deprecate old python versions (#157)

* update workflow before publishing python package

* fix dependency issue and bump version

* point to website in project description

* fix broken dependency

* improve doc

* add github token to download artifacts

* ensure only read-access @wvangeit

* yet another attempt at downloading artifacts

* make sure to use repo that ran the trigger wf

* another attempt at fixing

* change owner

* allow publishing to testpypi also when pr

* minor change

* revert minor (but breaking) change

* minor fix

* add debug messages

* another debug message

* hopefully the final version

* final fix

* minor fix

* move master and tag to individual jobs

* add debug messages

* dev->post

* add python script for determining semantic version

* minor changes

* minor changes

* improve error handling and add version file to artifacts

* check if release

* minor fix

* ensure to enter venv

* also when tagging

* source venv in publishin workflow

* ensure only master

* add script for testing 'pure' semver

* adapt workflows to new python script

* minor change

* attempt to evaluate expressions correctly

* several fixes to fix tests

* ensure repo is checked out in publish workflow

* several small fixes

* cleanup

* debug

* minor cleanup

* mionr changes

* add debug message

* minor change

* minor change

* yet another try

* minor change

* minor change

* minor change

* mionr change

* minor changes

* correct workflow run id

* cosmetic change

* avoid using gh

* change to a single job for publishing

* minor cleanup

* swap loops in clean up jobs

* correction

* update server compatibility to new url

* minor change to trigger ci

* update deprecation warnings

* ensure it works

* remove constraint on papermill version

* add icon

* correct readme

* update readme

* @pcrespov raise exception if retired python version

Author: bisgaard-itis

README.md

@@ -26,6 +26,14 @@ See the different `clients/<language>/README.md` for the workflows for generatin
     1. The openapi specification which is a json file located in `api/openapi.json`. This generated in [osparc-simcore](https://github.com/ITISFoundation/osparc-simcore/tree/master/services/api-server) and then moved here.
     2. The [openapi-generator](https://github.com/ITISFoundation/openapi-generator)-tool. The exact docker image of this tool to use is specifies in `scripts/common.Makefile`.
 
+## Code lifecycle
+This link explains the lifecycle of the osparc client(s) (borrowed from https://www.ibm.com/docs/en/acvfc?topic=manager-product-lifecycle)
+<p align="center">
+<a href="https://www.ibm.com/docs/en/acvfc?topic=manager-product-lifecycle" target="_blank">
+<image src="https://github.com/ITISFoundation/osparc-simcore-clients/blob/master/docs/_media/code_lifecycle.png?raw=true" alt="Code lifecycle" width="20%" />
+</a>
+</p>
+
 
 ## Documentation
 
@@ -37,3 +45,9 @@ Here is an inexhaustive list which have this repo as a dependency. So changing s
 
 - [e2e-portal-testing](https://git.speag.com/oSparc/e2e-portal-testing/-/commit/950762bde1a60c7ce23286da9c100150ed6926e4)
 - [osparc-simcore](https://github.com/ITISFoundation/osparc-simcore/actions/runs/5319311892/jobs/9631979977)
+
+<p align="center">
+<a href="https://www.z43.swiss" target="_blank">
+<image src="https://github.com/ITISFoundation/osparc-simcore-clients/blob/master/docs/_media/mwl.png?raw=true" alt="Made with love (and lots of hard work) at www.z43.swiss" width="20%" />
+</a>
+</p>

clients/python/client/osparc/__init__.py

@@ -1,3 +1,5 @@
+import warnings
+from platform import python_version
 from typing import List, Tuple
 
 import nest_asyncio
@@ -34,14 +36,35 @@
     ValidationError,
     __version__,
 )
+from packaging.version import Version
 
-from ._exceptions import RequestError
+from ._exceptions import RequestError, VisibleDeprecationWarning
 from ._files_api import FilesApi
 from ._info import openapi
 from ._solvers_api import SolversApi
 from ._studies_api import StudiesApi
 from ._utils import dev_features_enabled
 
+_PYTHON_VERSION_DEPRECATED = Version("3.6.0")
+_PYTHON_VERSION_SUPPORTED = Version("3.8.0")
+
+if Version(python_version()) < _PYTHON_VERSION_DEPRECATED:
+    error_msg: str = (
+        f"Python version {python_version()} is retired for this version of osparc. "
+        f"Please use Python version {_PYTHON_VERSION_SUPPORTED}."
+    )
+    raise RuntimeError(error_msg)
+
+if Version(python_version()) < _PYTHON_VERSION_SUPPORTED:
+    warning_msg: str = (
+        "This is the final version of osparc which "
+        f"will support Python {python_version()}. "
+        "Future versions of osparc will only support "
+        f"Python version >= {_PYTHON_VERSION_SUPPORTED}."
+    )
+    warnings.warn(warning_msg, VisibleDeprecationWarning)
+
+
 nest_asyncio.apply()  # allow to run coroutines via asyncio.run(coro)
 
 dev_features: List[str] = []

clients/python/client/osparc/models.py

@@ -1,5 +1,5 @@
 import warnings
-from typing import Final, Tuple
+from typing import Tuple
 
 from osparc_client.models import (
     BodyUploadFileV0FilesContentPut,
@@ -19,10 +19,11 @@
 
 from ._exceptions import VisibleDeprecationWarning
 
-warning_msg: Final[str] = (
+warning_msg: str = (
     "osparc.models has been deprecated. Instead functionality within this module "
     "should be imported directly from osparc. I.e. please do 'from osparc import "
-    "<fcn>' instead of 'from osparc.models import <fcn>'"
+    "<fcn>' instead of 'from osparc.models import <fcn>'. "
+    "Future version of osparc will not allow import of osparc.models."
 )
 warnings.warn(warning_msg, VisibleDeprecationWarning)
 

clients/python/client/setup.py

@@ -20,6 +20,7 @@
     "tqdm>=4.48.0",
     "nest_asyncio",
     "tenacity",
+    "packaging",
 ]
 
 setup(

clients/python/requirements/e2e-test.txt

@@ -7,7 +7,7 @@ jinja2
 matplotlib
 packaging
 pandas
-papermill<2.5.0 # due to bug in 2.5.0 (https://github.com/nteract/papermill/issues/735). Remove this requirement once the bug is fixed
+papermill
 pydantic
 pytest
 pytest-asyncio