Skip to content

Commit 0012e8a

Browse files
committed
refactor: rename mock function for clarity and consistency across tests
1 parent 0683a02 commit 0012e8a

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

services/web/server/tests/unit/with_dbs/02/test_projects_crud_handlers__patch.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ def mock_catalog_api_get_services_for_user_in_product(mocker: MockerFixture):
3232

3333

3434
@pytest.fixture
35-
def mock_project_uses_available_services(mocker: MockerFixture):
35+
def mock_are_project_services_available(mocker: MockerFixture):
3636
mocker.patch(
37-
"simcore_service_webserver.projects._controller.projects_rest.project_uses_available_services",
37+
"simcore_service_webserver.projects._controller.projects_rest.are_project_services_available",
3838
spec=True,
3939
return_value=True,
4040
)
@@ -82,7 +82,7 @@ async def test_patch_project(
8282
user_project: ProjectDict,
8383
expected: HTTPStatus,
8484
mock_catalog_api_get_services_for_user_in_product,
85-
mock_project_uses_available_services,
85+
mock_are_project_services_available,
8686
):
8787
assert client.app
8888
base_url = client.app.router["patch_project"].url_for(

services/web/server/tests/unit/with_dbs/02/test_projects_groups_handlers.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ def mock_catalog_api_get_services_for_user_in_product(
3333

3434

3535
@pytest.fixture
36-
def mock_project_uses_available_services(mocker: MockerFixture) -> MockType:
36+
def mock_are_project_services_available(mocker: MockerFixture) -> MockType:
3737
return mocker.patch(
38-
"simcore_service_webserver.projects._controller.projects_rest.project_uses_available_services",
38+
"simcore_service_webserver.projects._controller.projects_rest.are_project_services_available",
3939
spec=True,
4040
return_value=True,
4141
)
@@ -51,7 +51,7 @@ async def test_projects_groups_full_workflow( # noqa: PLR0915
5151
user_project: ProjectDict,
5252
expected: HTTPStatus,
5353
mock_catalog_api_get_services_for_user_in_product: MockType,
54-
mock_project_uses_available_services: MockType,
54+
mock_are_project_services_available: MockType,
5555
):
5656
assert client.app
5757
# check the default project permissions
@@ -265,7 +265,7 @@ async def test_share_project(
265265
logged_user: UserInfoDict,
266266
user_project: ProjectDict,
267267
mock_catalog_api_get_services_for_user_in_product: MockType,
268-
mock_project_uses_available_services: MockType,
268+
mock_are_project_services_available: MockType,
269269
):
270270
assert client.app
271271

@@ -333,7 +333,7 @@ async def test_share_project_with_roles(
333333
logged_user: UserInfoDict,
334334
user_project: ProjectDict,
335335
mock_catalog_api_get_services_for_user_in_product: MockType,
336-
mock_project_uses_available_services: MockType,
336+
mock_are_project_services_available: MockType,
337337
user_role: UserRole,
338338
expected_status: HTTPStatus,
339339
):

services/web/server/tests/unit/with_dbs/02/test_projects_nodes_handlers__patch.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ def mock_catalog_api_get_services_for_user_in_product(mocker: MockerFixture):
3636

3737

3838
@pytest.fixture
39-
def mock_project_uses_available_services(mocker: MockerFixture):
39+
def mock_are_project_services_available(mocker: MockerFixture):
4040
mocker.patch(
41-
"simcore_service_webserver.projects._controller.projects_rest.project_uses_available_services",
41+
"simcore_service_webserver.projects._controller.projects_rest.are_project_services_available",
4242
spec=True,
4343
return_value=True,
4444
)
@@ -100,7 +100,7 @@ async def test_patch_project_node(
100100
user_project: ProjectDict,
101101
expected: HTTPStatus,
102102
mock_catalog_api_get_services_for_user_in_product: None,
103-
mock_project_uses_available_services: None,
103+
mock_are_project_services_available: None,
104104
mock_catalog_rpc_check_for_service: None,
105105
):
106106
node_id = next(iter(user_project["workbench"]))
@@ -222,7 +222,7 @@ async def test_patch_project_node_notifies(
222222
user_project: ProjectDict,
223223
expected: HTTPStatus,
224224
mock_catalog_api_get_services_for_user_in_product,
225-
mock_project_uses_available_services,
225+
mock_are_project_services_available,
226226
mock_catalog_rpc_check_for_service,
227227
mocked_notify_project_node_update,
228228
):
@@ -258,7 +258,7 @@ async def test_patch_project_node_inputs_notifies(
258258
user_project: ProjectDict,
259259
expected: HTTPStatus,
260260
mock_catalog_api_get_services_for_user_in_product,
261-
mock_project_uses_available_services,
261+
mock_are_project_services_available,
262262
mocked_notify_project_node_update,
263263
):
264264
node_id = next(iter(user_project["workbench"]))
@@ -298,7 +298,7 @@ async def test_patch_project_node_inputs_with_data_type_change(
298298
user_project: ProjectDict,
299299
expected: HTTPStatus,
300300
mock_catalog_api_get_services_for_user_in_product,
301-
mock_project_uses_available_services,
301+
mock_are_project_services_available,
302302
):
303303
node_id = next(iter(user_project["workbench"]))
304304
assert client.app
@@ -351,7 +351,7 @@ async def test_patch_project_node_service_key_with_error(
351351
user_project: ProjectDict,
352352
expected: HTTPStatus,
353353
mock_catalog_api_get_services_for_user_in_product,
354-
mock_project_uses_available_services,
354+
mock_are_project_services_available,
355355
mocker: MockerFixture,
356356
):
357357
node_id = next(iter(user_project["workbench"]))

services/web/server/tests/unit/with_dbs/04/workspaces/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def mock_catalog_api_get_services_for_user_in_product(mocker: MockerFixture):
2626
return_value=[],
2727
)
2828
mocker.patch(
29-
"simcore_service_webserver.projects._controller.projects_rest.project_uses_available_services",
29+
"simcore_service_webserver.projects._controller.projects_rest.are_project_services_available",
3030
spec=True,
3131
return_value=True,
3232
)

0 commit comments

Comments
 (0)