Skip to content

Commit 001db74

Browse files
committed
need to be fixed
1 parent 8f8e966 commit 001db74

File tree

1 file changed

+2
-1
lines changed
  • packages/aws-library/src/aws_library/ec2

1 file changed

+2
-1
lines changed

packages/aws-library/src/aws_library/ec2/_models.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ class Resources(BaseModel, frozen=True):
4343
def create_as_empty(cls) -> "Resources":
4444
return cls(cpus=0, ram=ByteSize(0))
4545

46+
# TODO: this is not ok. everything shall be compared!
4647
def __ge__(self, other: "Resources") -> bool:
4748
"""operator for >= comparison
4849
if self has greater or equal resources than other, returns True
@@ -58,7 +59,7 @@ def __ge__(self, other: "Resources") -> bool:
5859

5960
def __gt__(self, other: "Resources") -> bool:
6061
"""operator for > comparison
61-
if self has any resources gretaer than other, returns True (even if different resource types are smaller)
62+
if self has any resources greater than other, returns True (even if different resource types are smaller)
6263
6364
Note that generic_resources are compared only if they are numeric
6465
Non-numeric generic resources must be equal in both or only defined in self

0 commit comments

Comments
 (0)