Skip to content

Commit 012abd0

Browse files
committed
added docs
1 parent 85e3fbb commit 012abd0

File tree

2 files changed

+15
-5
lines changed
  • packages/aws-library/src/aws_library/s3
  • services/dask-sidecar/src/simcore_service_dask_sidecar

2 files changed

+15
-5
lines changed

packages/aws-library/src/aws_library/s3/_client.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,12 @@ async def create(
8989
exit_stack = contextlib.AsyncExitStack()
9090
try:
9191
config = Config(
92-
signature_version="s3v4", request_checksum_calculation="when_required"
92+
# This setting tells the S3 client to only calculate checksums when explicitly required
93+
# by the operation. This avoids unnecessary checksum calculations for operations that
94+
# don't need them, improving performance.
95+
# See: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/s3.html#calculating-checksums
96+
signature_version="s3v4",
97+
request_checksum_calculation="when_required",
9398
)
9499
session_client = session.client( # type: ignore[call-overload]
95100
"s3",

services/dask-sidecar/src/simcore_service_dask_sidecar/file_utils.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,15 @@ def _s3fs_settings_from_s3_settings(s3_settings: S3Settings) -> S3FsSettingsDict
6969
s3fs_settings: S3FsSettingsDict = {
7070
"key": s3_settings.S3_ACCESS_KEY,
7171
"secret": s3_settings.S3_SECRET_KEY,
72-
"client_kwargs": {},
73-
"config_kwargs": {
74-
"request_checksum_calculation": "when_required",
75-
"signature_version": "s3v4",
72+
"client_kwargs": {
73+
"config_kwargs": {
74+
# This setting tells the S3 client to only calculate checksums when explicitly required
75+
# by the operation. This avoids unnecessary checksum calculations for operations that
76+
# don't need them, improving performance.
77+
# See: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/s3.html#calculating-checksums
78+
"request_checksum_calculation": "when_required",
79+
"signature_version": "s3v4",
80+
}
7681
},
7782
}
7883
if s3_settings.S3_REGION != _DEFAULT_AWS_REGION:

0 commit comments

Comments
 (0)