fixed broke ntests

Author: Andrei Neagu

packages/service-library/src/servicelib/long_running_tasks/task.py

@@ -385,9 +385,14 @@ async def remove_task(
             return
 
         if tracked_task.task_id in self._created_tasks:
-            # will have affect in the worker which deals with the removal
+            task_to_cancel = self._created_tasks.pop(tracked_task.task_id, None)
+            if task_to_cancel is not None:
+                # canceling the task affects the worker that started it.
+                # awaiting the cancelled task is a must since if the CancelledError
+                # was intercepted, those actions need to finish
+                await cancel_wait_task(task_to_cancel)
+
             await self._tasks_data.delete_task_data(task_id)
-            self._created_tasks.pop(tracked_task.task_id, None)
 
         # wait for task to be completed
         async for attempt in AsyncRetrying(

services/web/server/tests/unit/with_dbs/02/test_projects_cancellations.py

@@ -27,6 +27,7 @@
 from servicelib.rabbitmq.rpc_interfaces.async_jobs.async_jobs import (
     AsyncJobComposedResult,
 )
+from settings_library.redis import RedisSettings
 from simcore_postgres_database.models.users import UserRole
 from simcore_service_webserver._meta import api_version_prefix
 from simcore_service_webserver.application_settings import get_application_settings
@@ -40,7 +41,9 @@
 
 @pytest.fixture
 def app_environment(
-    app_environment: EnvVarsDict, monkeypatch: pytest.MonkeyPatch
+    use_in_memory_redis: RedisSettings,
+    app_environment: EnvVarsDict,
+    monkeypatch: pytest.MonkeyPatch,
 ) -> EnvVarsDict:
     envs_plugins = setenvs_from_dict(
         monkeypatch,
@@ -91,6 +94,7 @@ def _standard_user_role_response() -> (
 
 @pytest.mark.parametrize(*_standard_user_role_response())
 async def test_copying_large_project_and_aborting_correctly_removes_new_project(
+    mock_dynamic_scheduler: None,
     client: TestClient,
     logged_user: dict[str, Any],
     primary_group: dict[str, str],
@@ -142,6 +146,7 @@ async def test_copying_large_project_and_aborting_correctly_removes_new_project(
 
 @pytest.mark.parametrize(*_standard_user_role_response())
 async def test_copying_large_project_and_retrieving_copy_task(
+    mock_dynamic_scheduler: None,
     client: TestClient,
     logged_user: dict[str, Any],
     primary_group: dict[str, str],
@@ -296,6 +301,7 @@ async def test_copying_too_large_project_returns_422(
 ):
     assert client.app
     app_settings = get_application_settings(client.app)
+    assert app_settings.WEBSERVER_PROJECTS
     large_project_total_size = (
         app_settings.WEBSERVER_PROJECTS.PROJECTS_MAX_COPY_SIZE_BYTES + 1
     )