Skip to content

Commit 0302b4b

Browse files
reduce complexity
1 parent a34764d commit 0302b4b

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

packages/common-library/src/common_library/serialization.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,15 @@ def model_dump_with_secrets(
2020
data[field_name] = field_data.total_seconds()
2121

2222
elif isinstance(field_data, SecretStr):
23-
if show_secrets:
24-
data[field_name] = field_data.get_secret_value()
25-
else:
26-
data[field_name] = str(field_data)
23+
data[field_name] = field_data.get_secret_value() if show_secrets else str(field_data)
24+
2725

2826
elif isinstance(field_data, Url):
2927
data[field_name] = str(field_data)
3028

3129
elif isinstance(field_data, dict):
3230
field_type = get_origin(settings_obj.model_fields[field_name].annotation)
33-
if not field_type:
34-
continue
35-
if issubclass(field_type, BaseModel):
31+
if field_type and issubclass(field_type, BaseModel):
3632
data[field_name] = model_dump_with_secrets(
3733
field_type.model_validate(field_data),
3834
show_secrets=show_secrets,

0 commit comments

Comments
 (0)