add 404 in case result is not done

Author: bisgaard-itis

api/specs/web-server/_storage.py

@@ -226,6 +226,12 @@ async def abort_async_job(job_id: AsyncJobId):
     "/storage/async-jobs/{job_id}/result",
     response_model=Envelope[StorageAsyncJobResult],
     name="get_async_job_result",
+    responses={
+        status.HTTP_404_NOT_FOUND: {
+            "description": "Result not found",
+            "model": StorageAsyncJobStatus,
+        }
+    },
 )
 async def get_async_job_result(job_id: AsyncJobId):
     """Get the result of the async job"""

services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml

@@ -6477,12 +6477,18 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/Envelope_StorageAsyncJobResult_'
+        '404':
+          description: Result not found
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/StorageAsyncJobStatus'
   /v0/storage/async-jobs:
     get:
       tags:
       - storage
       summary: Get Async Jobs
-      description: Retrunsa list of async jobs for the user
+      description: Returns a list of async jobs for the user
       operationId: get_async_jobs
       parameters:
       - name: user_id

services/web/server/src/simcore_service_webserver/storage/_rest.py

@@ -544,6 +544,21 @@ async def get_async_job_result(request: web.Request) -> web.Response:
 
     rabbitmq_rpc_client = get_rabbitmq_rpc_client(request.app)
     async_job_get = parse_request_path_parameters_as(_StorageAsyncJobId, request)
+
+    async_job_rpc_status = await get_status(
+        rabbitmq_rpc_client=rabbitmq_rpc_client,
+        rpc_namespace=STORAGE_RPC_NAMESPACE,
+        job_id=async_job_get.job_id,
+        job_id_data=AsyncJobNameData(
+            user_id=_req_ctx.user_id, product_name=_req_ctx.product_name
+        ),
+    )
+    if not async_job_rpc_status.done:
+        return create_data_response(
+            async_job_rpc_status,
+            status=status.HTTP_404_NOT_FOUND,
+        )
+
     async_job_rpc_result = await get_result(
         rabbitmq_rpc_client=rabbitmq_rpc_client,
         rpc_namespace=STORAGE_RPC_NAMESPACE,
@@ -552,6 +567,7 @@ async def get_async_job_result(request: web.Request) -> web.Response:
             user_id=_req_ctx.user_id, product_name=_req_ctx.product_name
         ),
     )
+
     return create_data_response(
         StorageAsyncJobResult.from_rpc_schema(async_job_rpc_result),
         status=status.HTTP_200_OK,