[skip ci] more refactoring

Author: odeimaiz

services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js

@@ -431,7 +431,7 @@ qx.Class.define("osparc.dashboard.ResourceDetails", {
       if (
         osparc.utils.Resources.isService(resourceData) ||
         !osparc.product.Utils.showStudyPreview() ||
-        osparc.data.model.Study.getUiMode(resourceData) === "app"
+        osparc.study.Utils.getUiMode(resourceData) === "app"
       ) {
         // there is no pipelining or don't show it
         return null;

services/static-webserver/client/source/class/osparc/data/model/Study.js

@@ -301,20 +301,6 @@ qx.Class.define("osparc.data.model.Study", {
       return false;
     },
 
-    hasSlideshow: function(studyData) {
-      if ("ui" in studyData && "slideshow" in studyData["ui"] && Object.keys(studyData["ui"]["slideshow"]).length) {
-        return true;
-      }
-      return false;
-    },
-
-    getUiMode: function(studyData) {
-      if ("ui" in studyData && "mode" in studyData["ui"]) {
-        return studyData["ui"]["mode"];
-      }
-      return null;
-    },
-
     getOutputValue: function(studyData, nodeId, portId) {
       if ("workbench" in studyData &&
         nodeId in studyData["workbench"] &&
@@ -354,17 +340,6 @@ qx.Class.define("osparc.data.model.Study", {
         "RETRY"
       ].includes(state);
     },
-
-    __isAnyLinkedNodeMissing: function(studyData) {
-      const existingNodeIds = Object.keys(studyData["workbench"]);
-      const linkedNodeIds = osparc.data.model.Workbench.getLinkedNodeIds(studyData["workbench"]);
-      const allExist = linkedNodeIds.every(linkedNodeId => existingNodeIds.includes(linkedNodeId));
-      return !allExist;
-    },
-
-    isCorrupt: function(studyData) {
-      return this.__isAnyLinkedNodeMissing(studyData);
-    },
   },
 
   members: {

services/static-webserver/client/source/class/osparc/desktop/MainPageHandler.js

@@ -103,7 +103,7 @@ qx.Class.define("osparc.desktop.MainPageHandler", {
       }
 
       // check if it's corrupt
-      if (osparc.data.model.Study.isCorrupt(studyData)) {
+      if (osparc.study.Utils.isCorrupt(studyData)) {
         const msg = `${qx.locale.Manager.tr("We encountered an issue with the")} ${studyAlias} <br>${qx.locale.Manager.tr("Please contact support.")}`;
         throw new Error(msg);
       }

services/static-webserver/client/source/class/osparc/study/Utils.js

@@ -23,6 +23,17 @@ qx.Class.define("osparc.study.Utils", {
   type: "static",
 
   statics: {
+    __isAnyLinkedNodeMissing: function(studyData) {
+      const existingNodeIds = Object.keys(studyData["workbench"]);
+      const linkedNodeIds = osparc.data.model.Workbench.getLinkedNodeIds(studyData["workbench"]);
+      const allExist = linkedNodeIds.every(linkedNodeId => existingNodeIds.includes(linkedNodeId));
+      return !allExist;
+    },
+
+    isCorrupt: function(studyData) {
+      return this.__isAnyLinkedNodeMissing(studyData);
+    },
+
     extractServices: function(workbench) {
       const services = [];
       Object.values(workbench).forEach(srv => {
@@ -270,6 +281,13 @@ qx.Class.define("osparc.study.Utils", {
       return Boolean("debt" in studyData && studyData["debt"] < 0);
     },
 
+    getUiMode: function(studyData) {
+      if ("ui" in studyData && "mode" in studyData["ui"]) {
+        return studyData["ui"]["mode"];
+      }
+      return null;
+    },
+
     __getBlockedState: function(studyData) {
       if (studyData["workbench"]) {
         const unaccessibleServices = osparc.study.Utils.getInaccessibleServices(studyData["workbench"])