ensure notification error does not fail lock

Author: sanderegg

packages/service-library/src/servicelib/redis/_project_lock.py

@@ -1,17 +1,20 @@
 import functools
+import logging
 from collections.abc import Awaitable, Callable, Coroutine
 from typing import Any, Final, ParamSpec, TypeVar
 
 from models_library.projects import ProjectID
 from models_library.projects_access import Owner
 from models_library.projects_state import ProjectLocked, ProjectStatus
+from servicelib.logging_utils import log_catch
 
 from ._client import RedisClientSDK
 from ._decorators import exclusive
 from ._errors import CouldNotAcquireLockError, ProjectLockError
 
 _PROJECT_REDIS_LOCK_KEY: Final[str] = "project_lock:{}"
 
+_logger = logging.getLogger(__name__)
 
 P = ParamSpec("P")
 R = TypeVar("R")
@@ -59,7 +62,8 @@ async def _wrapper(*args: P.args, **kwargs: P.kwargs) -> R:
             )
             async def _exclusive_func(*args, **kwargs) -> R:
                 if notification_cb is not None:
-                    await notification_cb()
+                    with log_catch(_logger, reraise=False):
+                        await notification_cb()
                 return await func(*args, **kwargs)
 
             try:
@@ -70,7 +74,8 @@ async def _exclusive_func(*args, **kwargs) -> R:
             finally:
                 # we are now unlocked
                 if notification_cb is not None:
-                    await notification_cb()
+                    with log_catch(_logger, reraise=False):
+                        await notification_cb()
 
         return _wrapper