Skip to content

Commit 066628b

Browse files
committed
Make dv0 work with registry v3
1 parent d9aef02 commit 066628b

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

services/director/src/simcore_service_director/registry_proxy.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,23 @@ async def _basic_auth_registry_request(
7171
)
7272

7373
session = get_client_session(app)
74+
# Only accept docker distribution V1 registry protocol ,
75+
# dv0 does not have v2 compatability here, but from registry>=3.0.0
76+
# the v2 scheme is default...
77+
# https://specs.opencontainers.org/image-spec/media-types/?v=v1.0.1
78+
# https://distribution.github.io/distribution/spec/api/
7479
response = await session.request(
7580
method.lower(),
7681
f"{request_url}",
7782
auth=auth,
83+
headers={
84+
"Accept": ", ".join(
85+
[
86+
"application/vnd.oci.image.manifest.v1+json",
87+
"application/vnd.oci.image.index.v1+json",
88+
]
89+
)
90+
},
7891
**session_kwargs,
7992
)
8093

@@ -104,7 +117,7 @@ async def _basic_auth_registry_request(
104117
return (resp_data, resp_headers)
105118

106119

107-
async def _auth_registry_request( # noqa: C901
120+
async def _auth_registry_request( # noqa: C901#
108121
app_settings: ApplicationSettings,
109122
url: URL,
110123
method: str,

0 commit comments

Comments
 (0)