ensure queue is not ignored

Author: sanderegg

services/web/server/src/simcore_service_webserver/notifications/_rabbitmq_exclusive_queue_consumers.py

@@ -93,7 +93,7 @@ async def _progress_message_parser(app: web.Application, data: bytes) -> bool:
             app,
             rabbit_message.user_id,
             message=message,
-            ignore_queue=True,
+            ignore_queue=False,
         )
     return True
 
@@ -107,7 +107,7 @@ async def _log_message_parser(app: web.Application, data: bytes) -> bool:
             event_type=SOCKET_IO_LOG_EVENT,
             data=rabbit_message.model_dump(exclude={"user_id", "channel_name"}),
         ),
-        ignore_queue=True,
+        ignore_queue=False,
     )
     return True
 
@@ -124,7 +124,7 @@ async def _events_message_parser(app: web.Application, data: bytes) -> bool:
                 "node_id": f"{rabbit_message.node_id}",
             },
         ),
-        ignore_queue=True,
+        ignore_queue=False,
     )
     return True
 
@@ -178,9 +178,10 @@ async def _osparc_credits_message_parser(app: web.Application, data: bytes) -> b
 
 
 async def _unsubscribe_from_rabbitmq(app) -> None:
-    with log_context(
-        _logger, logging.INFO, msg="Unsubscribing from rabbitmq channels"
-    ), log_catch(_logger, reraise=False):
+    with (
+        log_context(_logger, logging.INFO, msg="Unsubscribing from rabbitmq channels"),
+        log_catch(_logger, reraise=False),
+    ):
         rabbit_client: RabbitMQClient = get_rabbitmq_client(app)
         await logged_gather(
             *(

services/web/server/src/simcore_service_webserver/payments/_socketio.py

@@ -29,7 +29,7 @@ async def notify_payment_completed(
             event_type=SOCKET_IO_PAYMENT_COMPLETED_EVENT,
             data=jsonable_encoder(payment, by_alias=True),
         ),
-        ignore_queue=True,
+        ignore_queue=False,
     )
 
 
@@ -46,5 +46,5 @@ async def notify_payment_method_acked(
             event_type=SOCKET_IO_PAYMENT_METHOD_ACKED_EVENT,
             data=jsonable_encoder(payment_method_transaction, by_alias=True),
         ),
-        ignore_queue=True,
+        ignore_queue=False,
     )

services/web/server/src/simcore_service_webserver/projects/_projects_service.py

@@ -1961,7 +1961,7 @@ async def notify_project_state_update(
             app,
             user_id=notify_only_user,
             message=message,
-            ignore_queue=True,
+            ignore_queue=False,
         )
     else:
         rooms_to_notify: Generator[GroupID, None, None] = (

services/web/server/src/simcore_service_webserver/socketio/messages.py

@@ -62,12 +62,12 @@ async def send_message_to_user(
     user_id: UserID,
     message: SocketMessageDict,
     *,
-    ignore_queue: bool,
+    ignore_queue: bool = False,
 ) -> None:
     """
     Keyword Arguments:
-        ignore_queue -- set to False when this message is delivered from a server that has no direct connection to the client (default: {True})
-        An example where this is value is False, is sending messages to a user in the GC
+        ignore_queue -- set to True when this message is delivered from a server that has no direct connection to the user client (default: {False})
+        Be careful with this option, as it can lead to message loss if the user is not connected to this server!!
     """
     sio: AsyncServer = get_socket_server(app)