Skip to content

Commit 079dd64

Browse files
committed
make typecheck happy in api-server
1 parent 3e893d9 commit 079dd64

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

services/api-server/src/simcore_service_api_server/_service_function_jobs.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,14 @@ async def inspect_function_job(
134134
function.function_class == FunctionClass.PROJECT
135135
and function_job.function_class == FunctionClass.PROJECT
136136
):
137+
assert function_job.project_job_id is not None # nosec
137138
job_status = await self._job_service.inspect_study_job(
138139
job_id=function_job.project_job_id,
139140
)
140141
elif (function.function_class == FunctionClass.SOLVER) and (
141142
function_job.function_class == FunctionClass.SOLVER
142143
):
144+
assert function_job.solver_job_id is not None # nosec
143145
job_status = await self._job_service.inspect_solver_job(
144146
solver_key=function.solver_key,
145147
version=function.solver_version,

services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from typing import Annotated, Final
22

3-
from fastapi import APIRouter, Depends, FastAPI, status
3+
from fastapi import APIRouter, Depends, FastAPI, HTTPException, status
44
from fastapi_pagination.api import create_page
55
from fastapi_pagination.bases import AbstractPage
66
from models_library.api_schemas_long_running_tasks.tasks import TaskGet
@@ -266,6 +266,7 @@ async def function_job_outputs(
266266
function.function_class == FunctionClass.PROJECT
267267
and function_job.function_class == FunctionClass.PROJECT
268268
):
269+
assert function_job.project_job_id is not None # nosec
269270
new_outputs = dict(
270271
(
271272
await studies_jobs.get_study_job_outputs(
@@ -281,6 +282,7 @@ async def function_job_outputs(
281282
function.function_class == FunctionClass.SOLVER
282283
and function_job.function_class == FunctionClass.SOLVER
283284
):
285+
assert function_job.solver_job_id is not None # nosec
284286
new_outputs = dict(
285287
(
286288
await solvers_jobs_read.get_job_outputs(
@@ -337,6 +339,11 @@ async def get_function_job_logs_task(
337339
function.function_class == FunctionClass.PROJECT
338340
and function_job.function_class == FunctionClass.PROJECT
339341
):
342+
if function_job.project_job_id is None:
343+
raise HTTPException(
344+
status_code=status.HTTP_404_NOT_FOUND,
345+
detail="Could not find project job",
346+
)
340347
async_job_get = await job_service.start_log_export(
341348
job_id=function_job.project_job_id,
342349
)
@@ -353,6 +360,11 @@ async def get_function_job_logs_task(
353360
function.function_class == FunctionClass.SOLVER
354361
and function_job.function_class == FunctionClass.SOLVER
355362
):
363+
if function_job.solver_job_id is None:
364+
raise HTTPException(
365+
status_code=status.HTTP_404_NOT_FOUND,
366+
detail="Could not find solver job",
367+
)
356368
async_job_get = await job_service.start_log_export(
357369
job_id=function_job.solver_job_id,
358370
)

0 commit comments

Comments
 (0)