error-code

Author: pcrespov

packages/service-library/src/servicelib/logging_errors.py

@@ -2,7 +2,7 @@
 from pprint import pformat
 from typing import Any, NotRequired, TypedDict
 
-from models_library.error_codes import ErrorCodeStr, create_error_code
+from models_library.error_codes import ErrorCodeStr
 from models_library.errors_classes import OsparcErrorMixin
 
 from .logging_utils import LogExtra, get_log_record_extra
@@ -48,7 +48,9 @@ class LogKwargs(TypedDict):
 
 def create_troubleshotting_log_kwargs(
     user_error_msg: str,
+    *,
     error: BaseException,
+    error_code: ErrorCodeStr | None = None,
     error_context: dict[str, Any] | None = None,
     tip: str | None = None,
 ) -> LogKwargs:
@@ -69,9 +71,6 @@ def create_troubleshotting_log_kwargs(
             )
 
     """
-    # error-code
-    error_code = create_error_code(error)
-
     # error-context
     context = error_context or {}
     if isinstance(error, OsparcErrorMixin):

services/api-server/src/simcore_service_api_server/exceptions/handlers/_handlers_factory.py

@@ -35,13 +35,16 @@ async def _http_error_handler(
         if add_exception_to_message:
             user_error_msg += f" {exception}"
 
+        error_code = create_error_code(exception)
         if add_oec_to_message:
-            error_code = create_error_code(exception)
             user_error_msg += f" [{error_code}]"
 
         _logger.exception(
             **create_troubleshotting_log_kwargs(
-                user_error_msg, error=exception, tip="Unexpected error"
+                user_error_msg,
+                error=exception,
+                error_code=error_code,
+                tip="Unexpected error",
             )
         )
         return create_error_json_response(user_error_msg, status_code=status_code)