dont store values in a dict, use generator directly

Author: bisgaard-itis

services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py

@@ -1,4 +1,5 @@
 import logging
+from collections.abc import Generator
 from dataclasses import dataclass, field
 from datetime import timedelta
 from typing import Final, cast
@@ -47,17 +48,19 @@ def __post_init__(self) -> None:
         )
 
     def update_metrics(
-        self, log_queue_sizes: dict[JobID, int], health_check_failure_count: PositiveInt
+        self,
+        log_queue_sizes: Generator[tuple[JobID, int]],
+        health_check_failure_count: PositiveInt,
     ):
         self._health_check_qauge.set(health_check_failure_count)
         self._logstreaming_queues.clear()
-        for job_id, length in log_queue_sizes.items():
+        for job_id, length in log_queue_sizes:
             self._logstreaming_queues.labels(job_id=job_id).set(length)
 
 
 async def _collect_prometheus_metrics_task(app: FastAPI):
     get_instrumentation(app).update_metrics(
-        log_queue_sizes=get_log_distributor(app).get_log_queue_sizes,
+        log_queue_sizes=get_log_distributor(app).log_queue_sizes,
         health_check_failure_count=get_health_checker(app).health_check_failure_count,
     )
 

services/api-server/src/simcore_service_api_server/services_http/log_streaming.py

@@ -1,7 +1,7 @@
 import asyncio
 import logging
 from asyncio import Queue
-from collections.abc import AsyncIterable
+from collections.abc import AsyncIterable, Generator
 from typing import Final
 
 from common_library.error_codes import create_error_code
@@ -86,8 +86,9 @@ async def deregister(self, job_id: JobID):
         del self._log_streamers[job_id]
 
     @property
-    def get_log_queue_sizes(self) -> dict[JobID, int]:
-        return {k: v.qsize() for k, v in self._log_streamers.items()}
+    def log_queue_sizes(self) -> Generator[tuple[JobID, int]]:
+        for k, v in self._log_streamers.items():
+            yield k, v.qsize()
 
 
 class LogStreamer: