fixes tests

Author: pcrespov

services/web/server/src/simcore_service_webserver/projects/_controller/access_rights_rest.py

@@ -72,15 +72,20 @@ async def share_project(request: web.Request):
         )
 
         _logger.debug(
-            "Send email with confirmation link %s to %s ",
+            "Send email with confirmation link %s to %s with %s ",
             confirmation_link,
             body_params.sharee_email,
+            (
+                f"message {body_params.sharer_message}"
+                if body_params.sharer_message
+                else "no message"
+            ),
         )
 
+        data = ProjectShareAccepted(sharee_email=body_params.sharee_email, confirmation_link=confirmation_link)  # type: ignore
+
         return web.json_response(
-            Envelope[ProjectShareAccepted]
-            .from_data({"confirmation_link": confirmation_link})
-            .model_dump(),
+            Envelope[ProjectShareAccepted].from_data(data).model_dump(),
             dumps=json_dumps,
             status=status.HTTP_202_ACCEPTED,
         )

services/web/server/tests/unit/with_dbs/02/test_projects_groups_handlers.py

@@ -12,6 +12,7 @@
 from models_library.api_schemas_webserver.projects_access_rights import (
     ProjectShareAccepted,
 )
+from pytest_mock import MockType
 from pytest_mock.plugin import MockerFixture
 from pytest_simcore.helpers.assert_checks import assert_status
 from pytest_simcore.helpers.webserver_login import NewUser, UserInfoDict
@@ -21,17 +22,19 @@
 
 
 @pytest.fixture
-def mock_catalog_api_get_services_for_user_in_product(mocker: MockerFixture):
-    mocker.patch(
+def mock_catalog_api_get_services_for_user_in_product(
+    mocker: MockerFixture,
+) -> MockType:
+    return mocker.patch(
         "simcore_service_webserver.projects._controller.projects_rest.catalog_service.get_services_for_user_in_product",
         spec=True,
         return_value=[],
     )
 
 
 @pytest.fixture
-def mock_project_uses_available_services(mocker: MockerFixture):
-    mocker.patch(
+def mock_project_uses_available_services(mocker: MockerFixture) -> MockType:
+    return mocker.patch(
         "simcore_service_webserver.projects._controller.projects_rest.project_uses_available_services",
         spec=True,
         return_value=True,
@@ -47,8 +50,8 @@ async def test_projects_groups_full_workflow(  # noqa: PLR0915
     logged_user: UserInfoDict,
     user_project: ProjectDict,
     expected: HTTPStatus,
-    mock_catalog_api_get_services_for_user_in_product,
-    mock_project_uses_available_services,
+    mock_catalog_api_get_services_for_user_in_product: MockType,
+    mock_project_uses_available_services: MockType,
 ):
     assert client.app
     # check the default project permissions
@@ -261,8 +264,8 @@ async def test_share_project(
     client: TestClient,
     logged_user: UserInfoDict,
     user_project: ProjectDict,
-    mock_catalog_api_get_services_for_user_in_product,
-    mock_project_uses_available_services,
+    mock_catalog_api_get_services_for_user_in_product: MockType,
+    mock_project_uses_available_services: MockType,
 ):
     assert client.app
 
@@ -297,3 +300,19 @@ async def test_share_project(
     assert data[0]["read"] is True
     assert data[0]["write"] is True
     assert data[0]["delete"] is True
+
+    # check an invalid
+    url = client.app.router["share_project"].url_for(
+        project_id=f"{user_project['uuid']}"
+    )
+    resp = await client.post(
+        f"{url}",
+        json={
+            "shareeEmail": "[email protected]",
+            # invalid access rights combination
+            "read": True,
+            "write": False,
+            "delete": True,
+        },
+    )
+    await assert_status(resp, status.HTTP_422_UNPROCESSABLE_ENTITY)