Skip to content

Commit 089b924

Browse files
committed
rm unused in web-server
1 parent 71dc461 commit 089b924

File tree

4 files changed

+6
-80
lines changed

4 files changed

+6
-80
lines changed

services/web/server/src/simcore_service_webserver/catalog/_api.py

Lines changed: 2 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import logging
2-
import warnings
32
from collections.abc import Iterator
43
from typing import Any, cast
54

@@ -183,55 +182,6 @@ async def list_services(
183182
return services
184183

185184

186-
async def get_service(
187-
service_key: ServiceKey, service_version: ServiceVersion, ctx: CatalogRequestContext
188-
) -> dict[str, Any]:
189-
190-
warnings.warn(
191-
"`get_service` is deprecated, use `get_service_v2` instead",
192-
DeprecationWarning,
193-
stacklevel=1,
194-
)
195-
196-
service = await client.get_service(
197-
ctx.app, ctx.user_id, service_key, service_version, ctx.product_name
198-
)
199-
await replace_service_input_outputs(
200-
service,
201-
unit_registry=ctx.unit_registry,
202-
**RESPONSE_MODEL_POLICY,
203-
)
204-
return service
205-
206-
207-
async def update_service(
208-
service_key: ServiceKey,
209-
service_version: ServiceVersion,
210-
update_data: dict[str, Any],
211-
ctx: CatalogRequestContext,
212-
):
213-
warnings.warn(
214-
"`update_service_v2` is deprecated, use `update_service_v2` instead",
215-
DeprecationWarning,
216-
stacklevel=1,
217-
)
218-
219-
service = await client.update_service(
220-
ctx.app,
221-
ctx.user_id,
222-
service_key,
223-
service_version,
224-
ctx.product_name,
225-
update_data,
226-
)
227-
await replace_service_input_outputs(
228-
service,
229-
unit_registry=ctx.unit_registry,
230-
**RESPONSE_MODEL_POLICY,
231-
)
232-
return service
233-
234-
235185
async def list_service_inputs(
236186
service_key: ServiceKey, service_version: ServiceVersion, ctx: CatalogRequestContext
237187
) -> list[ServiceInputGet]:
@@ -294,7 +244,7 @@ async def get_compatible_inputs_given_source_output(
294244
def iter_service_inputs() -> Iterator[tuple[ServiceInputKey, ServiceInput]]:
295245
for service_input in service_inputs:
296246
yield service_input.key_id, ServiceInput.model_construct(
297-
**service_input.model_dump(include=ServiceInput.model_fields.keys()) # type: ignore[arg-type]
247+
**service_input.model_dump(include=ServiceInput.model_fields.keys()) # type: ignore[arg-type]
298248
)
299249

300250
# check
@@ -361,7 +311,7 @@ def iter_service_outputs() -> Iterator[tuple[ServiceOutputKey, ServiceOutput]]:
361311
to_service_key, to_service_version, to_input_key, ctx
362312
)
363313
to_input: ServiceInput = ServiceInput.model_construct(
364-
**service_input.model_dump(include=ServiceInput.model_fields.keys()) # type: ignore[arg-type]
314+
**service_input.model_dump(include=ServiceInput.model_fields.keys()) # type: ignore[arg-type]
365315
)
366316

367317
# check

services/web/server/src/simcore_service_webserver/catalog/client.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -169,27 +169,3 @@ async def get_service_access_rights(
169169
resp.raise_for_status()
170170
body = await resp.json()
171171
return ServiceAccessRightsGet.model_validate(body)
172-
173-
174-
async def update_service(
175-
app: web.Application,
176-
user_id: UserID,
177-
service_key: str,
178-
service_version: str,
179-
product_name: str,
180-
update_data: dict[str, Any],
181-
) -> dict[str, Any]:
182-
settings: CatalogSettings = get_plugin_settings(app)
183-
184-
url = URL(
185-
f"{settings.api_base_url}/services/{urllib.parse.quote_plus(service_key)}/{service_version}",
186-
encoded=True,
187-
).with_query({"user_id": user_id})
188-
189-
with _handle_client_exceptions(app) as session:
190-
async with session.patch(
191-
url, headers={X_PRODUCT_NAME_HEADER: product_name}, json=update_data
192-
) as resp:
193-
resp.raise_for_status()
194-
body: dict[str, Any] = await resp.json()
195-
return body

services/web/server/tests/unit/with_dbs/01/test_catalog_handlers__pricing_plan.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def mock_rut_api_responses(
3030
settings: ResourceUsageTrackerSettings = get_plugin_settings(client.app)
3131

3232
service_pricing_plan_get = PricingPlanGet.model_validate(
33-
PricingPlanGet.model_config["json_schema_extra"]["examples"][0],
33+
PricingPlanGet.model_json_schema()["examples"][0],
3434
)
3535
aioresponses_mocker.get(
3636
re.compile(f"^{settings.api_base_url}/services/+.+$"),

services/web/server/tests/unit/with_dbs/01/test_catalog_handlers__services.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ async def _list(
5656
assert user_id
5757

5858
items = TypeAdapter(list[ServiceGetV2]).validate_python(
59-
ServiceGetV2.model_config["json_schema_extra"]["examples"],
59+
ServiceGetV2.model_json_schema()["examples"],
6060
)
6161
total_count = len(items)
6262

@@ -80,7 +80,7 @@ async def _get(
8080
assert user_id
8181

8282
got = ServiceGetV2.model_validate(
83-
ServiceGetV2.model_config["json_schema_extra"]["examples"][0]
83+
ServiceGetV2.model_json_schema()["examples"][0]
8484
)
8585
got.version = service_version
8686
got.key = service_key
@@ -101,7 +101,7 @@ async def _update(
101101
assert user_id
102102

103103
got = ServiceGetV2.model_validate(
104-
ServiceGetV2.model_config["json_schema_extra"]["examples"][0]
104+
ServiceGetV2.model_json_schema()["examples"][0]
105105
)
106106
got.version = service_version
107107
got.key = service_key

0 commit comments

Comments
 (0)