minor

Author: sanderegg

packages/aws-library/src/aws_library/ec2/_client.py

@@ -96,6 +96,11 @@ async def get_ec2_instance_capabilities(
         list_instances: list[EC2InstanceType] = []
         for instance in instance_types.get("InstanceTypes", []):
             with contextlib.suppress(KeyError):
+                assert "InstanceType" in instance  # nosec
+                assert "VCpuInfo" in instance  # nosec
+                assert "DefaultVCpus" in instance["VCpuInfo"]  # nosec
+                assert "MemoryInfo" in instance  # nosec
+                assert "SizeInMiB" in instance["MemoryInfo"]  # nosec
                 list_instances.append(
                     EC2InstanceType(
                         name=instance["InstanceType"],

packages/aws-library/tests/test_ec2_client.py

@@ -625,14 +625,8 @@ async def mock_run_instances(*args, **kwargs) -> Any:
                     "Code": "InsufficientInstanceCapacity",
                     "Message": "Insufficient capacity.",
                 },
-                "ResponseMetadata": {
-                    "RequestId": "12345678-1234-1234-1234-123456789012",
-                    "HTTPStatusCode": 400,
-                    "HTTPHeaders": {},
-                    "RetryAttempts": 0,
-                },
             }
-            raise botocore.exceptions.ClientError(error_response, "RunInstances")
+            raise botocore.exceptions.ClientError(error_response, "RunInstances")  # type: ignore
         # Second call (second subnet) - succeed normally
         assert kwargs["NetworkInterfaces"][0]["SubnetId"] == subnet2_id
         return await original_run_instances(*args, **kwargs)
@@ -715,14 +709,8 @@ async def mock_run_instances(*args, **kwargs) -> Any:
                 "Code": "InsufficientInstanceCapacity",
                 "Message": "Insufficient capacity.",
             },
-            "ResponseMetadata": {
-                "RequestId": "12345678-1234-1234-1234-123456789012",
-                "HTTPStatusCode": 400,
-                "HTTPHeaders": {},
-                "RetryAttempts": 0,
-            },
         }
-        raise botocore.exceptions.ClientError(error_response, "RunInstances")
+        raise botocore.exceptions.ClientError(error_response, "RunInstances")  # type: ignore
 
     # Apply the mock and expect EC2InsufficientCapacityError
     mocker.patch.object(
@@ -798,14 +786,8 @@ async def mock_run_instances(*args, **kwargs):
                 "Code": "InsufficientInstanceCapacity",
                 "Message": "Insufficient capacity.",
             },
-            "ResponseMetadata": {
-                "RequestId": "12345678-1234-1234-1234-123456789012",
-                "HTTPStatusCode": 400,
-                "HTTPHeaders": {},
-                "RetryAttempts": 0,
-            },
         }
-        raise botocore.exceptions.ClientError(error_response, "RunInstances")
+        raise botocore.exceptions.ClientError(error_response, "RunInstances")  # type: ignore
 
     # Apply the mock for the first call
     mocker.patch.object(