start creating patch endpoint for function jobs

Author: bisgaard-itis

services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rpc.py

@@ -20,6 +20,7 @@
     RegisteredFunction,
     RegisteredFunctionJob,
     RegisteredFunctionJobCollection,
+    RegisteredFunctionJobPatch,
 )
 from models_library.functions_errors import (
     FunctionIDNotFoundError,
@@ -99,13 +100,16 @@ async def patch_registered_function_job(
     *,
     user_id: UserID,
     product_name: ProductName,
-    registered_function_job: RegisteredFunctionJob,
+    function_job_uuid: FunctionJobID,
+    registered_function_job_patch: RegisteredFunctionJobPatch,
 ) -> RegisteredFunctionJob:
+
     return await _functions_service.patch_registered_function_job(
         app=app,
         user_id=user_id,
         product_name=product_name,
-        registered_function_job=registered_function_job,
+        function_job_uuid=function_job_uuid,
+        registered_function_job_patch=registered_function_job_patch,
     )
 
 

services/web/server/src/simcore_service_webserver/functions/_functions_repository.py

@@ -234,6 +234,50 @@ async def create_function_job(  # noqa: PLR0913
     return registered_function_job
 
 
+async def patch_function_job(  # noqa: PLR0913
+    app: web.Application,
+    connection: AsyncConnection | None = None,
+    *,
+    user_id: UserID,
+    product_name: ProductName,
+    function_job_uuid: FunctionJobID,
+    title: str | None,
+    description: str | None,
+    **class_specific_data: FunctionJobClassSpecificData | None,
+) -> RegisteredFunctionJobDB:
+
+    update_params = {
+        "title": title,
+        "description": description,
+        "class_specific_data": class_specific_data,
+    }
+
+    async with transaction_context(get_asyncpg_engine(app), connection) as transaction:
+        await check_user_api_access_rights(
+            app,
+            connection=transaction,
+            user_id=user_id,
+            product_name=product_name,
+            api_access_rights=[
+                FunctionsApiAccessRights.WRITE_FUNCTION_JOBS,
+            ],
+        )
+        result = await transaction.execute(
+            function_jobs_table.update()
+            .where(function_jobs_table.c.uuid == function_job_uuid)
+            .values(
+                status="created",
+                **{k: v for k, v in update_params.items() if v is not None},
+            )
+            .returning(*_FUNCTION_JOBS_TABLE_COLS)
+        )
+        row = result.one()
+
+        registered_function_job = RegisteredFunctionJobDB.model_validate(row)
+
+    return registered_function_job
+
+
 async def create_function_job_collection(
     app: web.Application,
     connection: AsyncConnection | None = None,

services/web/server/src/simcore_service_webserver/functions/_functions_service.py

@@ -27,6 +27,7 @@
     RegisteredFunctionJob,
     RegisteredFunctionJobCollection,
     RegisteredFunctionJobDB,
+    RegisteredFunctionJobPatch,
     RegisteredProjectFunction,
     RegisteredProjectFunctionJob,
     RegisteredSolverFunction,
@@ -100,10 +101,26 @@ async def patch_registered_function_job(
     *,
     user_id: UserID,
     product_name: ProductName,
-    registered_function_job: RegisteredFunctionJob,
+    function_job_uuid: FunctionJobID,
+    registered_function_job_patch: RegisteredFunctionJobPatch,
 ) -> RegisteredFunctionJob:
-    encoded_function_job = _encode_functionjob(registered_function_job)
-    return registered_function_job
+    job = await _functions_repository.get_function_job(
+        app=app,
+        user_id=user_id,
+        product_name=product_name,
+        function_job_id=function_job_uuid,
+    )
+
+    await _functions_repository.patch_function_job(
+        app=app,
+        function_job_uuid=function_job_uuid,
+        user_id=user_id,
+        product_name=product_name,
+        title=title,
+        description=description,
+        class_specific_data=class_specific_data,
+    )
+    return _decode_functionjob(job)
 
 
 async def register_function_job_collection(

services/web/server/tests/unit/with_dbs/04/functions/test_function_jobs_controller_rpc.py

@@ -16,7 +16,6 @@
     FunctionClass,
     FunctionJobCollection,
     FunctionJobStatus,
-    RegisteredProjectFunctionJob,
 )
 from models_library.functions_errors import (
     FunctionJobIDNotFoundError,
@@ -476,24 +475,26 @@ async def test_patch_registered_function_jobs(
     )
 
     added_data = {"job_creation_task_id": f"{uuid4()}"}
-    registered_job_dict = registered_job.model_dump()
-    registered_job_dict.update(**added_data)
-    registered_job = RegisteredProjectFunctionJob.model_validate(registered_job_dict)
 
     registered_job = await functions_rpc.patch_registered_function_job(
         rabbitmq_rpc_client=rpc_client,
         user_id=logged_user["id"],
+        function_job_uuid=registered_job.uid,
         product_name=osparc_product_name,
-        registered_function_job=registered_job,
+        job_creation_task_id=added_data["job_creation_task_id"],
     )
     assert registered_job.function_class == FunctionClass.PROJECT
     assert registered_job.job_creation_task_id == added_data["job_creation_task_id"]
 
     added_data.update(project_job_id=f"{uuid4()}")
 
-    registered_job_dict = registered_job.model_dump()
-    registered_job_dict.update(**added_data)
-    registered_job = RegisteredProjectFunctionJob.model_validate(registered_job_dict)
+    registered_job = await functions_rpc.patch_registered_function_job(
+        rabbitmq_rpc_client=rpc_client,
+        user_id=logged_user["id"],
+        function_job_uuid=registered_job.uid,
+        product_name=osparc_product_name,
+        project_job_id=added_data["project_job_id"],
+    )
     assert registered_job.function_class == FunctionClass.PROJECT
     assert registered_job.job_creation_task_id == added_data["job_creation_task_id"]
     assert registered_job.project_job_id == UUID(added_data["project_job_id"])