pipeline running to secondary column

Author: odeimaiz

services/static-webserver/client/source/class/osparc/data/model/Node.js

@@ -599,23 +599,6 @@ qx.Class.define("osparc.data.model.Node", {
 
     __applyPropsForm: function(propsForm) {
       osparc.utils.Utils.setIdToWidget(propsForm, "settingsForm_" + this.getNodeId());
-
-      const checkIsPipelineRunning = () => {
-        const isPipelineRunning = this.getStudy().isPipelineRunning();
-        this.getPropsForm().setEnabled(!isPipelineRunning);
-      };
-      this.getStudy().addListener("changeState", () => checkIsPipelineRunning(), this);
-
-      // potentially disabling the inputs form might have side effects if the deserialization is not over
-      if (this.getWorkbench().isDeserialized()) {
-        checkIsPipelineRunning();
-      } else {
-        this.getWorkbench().addListener("changeDeserialized", e => {
-          if (e.getData()) {
-            checkIsPipelineRunning();
-          }
-        }, this);
-      }
     },
 
     /**

services/static-webserver/client/source/class/osparc/desktop/WorkbenchView.js

@@ -798,6 +798,12 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
       } else if (node) {
         this.__populateSecondaryColumnNode(node);
       }
+
+      if (node instanceof osparc.data.model.Node) {
+        node.getStudy().bind("pipelineRunning", this.__serviceOptionsPage, "enabled", {
+          converter: pipelineRunning => !pipelineRunning
+        });
+      }
     },
 
     __populateSecondaryColumnStudy: function(study) {

services/static-webserver/client/source/class/osparc/node/slideshow/BaseNodeView.js

@@ -277,13 +277,6 @@ qx.Class.define("osparc.node.slideshow.BaseNodeView", {
       return this._settingsLayout;
     },
 
-    /**
-      * @abstract
-      */
-    isSettingsGroupShowable: function() {
-      throw new Error("Abstract method called!");
-    },
-
     /**
       * @abstract
       */

services/static-webserver/client/source/class/osparc/node/slideshow/FilePickerView.js

@@ -27,11 +27,6 @@ qx.Class.define("osparc.node.slideshow.FilePickerView", {
   },
 
   members: {
-    // overridden
-    isSettingsGroupShowable: function() {
-      return false;
-    },
-
     // overridden
     _addSettings: function() {
       return;

services/static-webserver/client/source/class/osparc/node/slideshow/NodeView.js

@@ -59,7 +59,13 @@ qx.Class.define("osparc.node.slideshow.NodeView", {
       if (propsForm && node.hasInputs()) {
         this._settingsLayout.add(propsForm);
       }
-      this.__checkSettingsVisibility();
+
+      const showSettings = node.isComputational();
+      this._settingsLayout.setVisibility(showSettings ? "visible" : "excluded");
+
+      node.getStudy().bind("pipelineRunning", this._settingsLayout, "enabled", {
+        converter: pipelineRunning => !pipelineRunning
+      });
 
       this._mainView.add(this._settingsLayout);
     },
@@ -128,19 +134,6 @@ qx.Class.define("osparc.node.slideshow.NodeView", {
       this.base(arguments, node);
     },
 
-    __checkSettingsVisibility: function() {
-      const isSettingsGroupShowable = this.isSettingsGroupShowable();
-      this._settingsLayout.setVisibility(isSettingsGroupShowable ? "visible" : "excluded");
-    },
-
-    isSettingsGroupShowable: function() {
-      const node = this.getNode();
-      if (node.isComputational()) {
-        return this.self().isPropsFormShowable(node);
-      }
-      return false;
-    },
-
     __iFrameChanged: function() {
       this._iFrameLayout.removeAll();