do not allow manual intervention for steps that are repeatable

Author: Andrei Neagu

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_operation.py

@@ -277,6 +277,17 @@ def _validate_operation(operation: Operation) -> dict[StepName, type[BaseStep]]:
                     raise ValueError(msg)
                 revert_provided_keys.add(key)
 
+        if k == len(operation) - 1 and step_group.repeat_steps is True:
+            if any(
+                step.wait_for_manual_intervention()
+                for step in step_group.get_step_subgroup_to_run()
+            ):
+                msg = (
+                    "Step groups with repeat_steps=True cannot have steps that require "
+                    "manual intervention. This would lead to a deadlock."
+                )
+                raise ValueError(msg)
+
     return detected_steps_names
 
 

services/dynamic-scheduler/tests/unit/service_generic_scheduler/test__operation.py

@@ -39,6 +39,12 @@ class BS2(BaseBS): ...
 class BS3(BaseBS): ...
 
 
+class MI1(BaseBS):
+    @classmethod
+    def wait_for_manual_intervention(cls) -> bool:
+        return True
+
+
 class WrongBS1C(BaseBS):
     @classmethod
     def get_create_provides_operation_context_keys(cls) -> set[str]:
@@ -150,6 +156,16 @@ def test_validate_operation_passes(operation: Operation):
             [ParallelStepGroup(WrongBS1R, WrongBS2R)],
             f"already provided key='revert_key' in {BaseStep.get_revert_provides_operation_context_keys.__name__}",
         ),
+        (
+            [SingleStepGroup(MI1, repeat_steps=True)],
+            "cannot have steps that require manual intervention",
+        ),
+        (
+            [
+                ParallelStepGroup(MI1, BS1, BS2, repeat_steps=True),
+            ],
+            "cannot have steps that require manual intervention",
+        ),
     ],
 )
 def test_validate_operations_fails(operation: Operation, match: str):