Skip to content

Commit 0b4e750

Browse files
committed
progress on gh workflow
1 parent 18e0f14 commit 0b4e750

File tree

1 file changed

+21
-9
lines changed

1 file changed

+21
-9
lines changed

.github/workflows/ci-testing-deploy.yml

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2868,11 +2868,10 @@ jobs:
28682868
api-server-api-spec-backwards-compatible:
28692869
needs: [changes]
28702870
if: ${{ needs.changes.outputs.anything == 'true' || github.event_name == 'push' }}
2871-
timeout-minutes: 5
2872-
name: "api-server-backwards-compatibility"
2871+
timeout-minutes: 10
2872+
name: "api-specs-backwards-compatibility"
28732873
runs-on: ubuntu-latest
28742874
steps:
2875-
- uses: actions/checkout@v4
28762875
- name: setup python environment
28772876
uses: actions/setup-python@v5
28782877
with:
@@ -2883,10 +2882,23 @@ jobs:
28832882
version: "0.4.x"
28842883
enable-cache: false
28852884
cache-dependency-glob: "**/service-library/requirements/ci*.txt"
2886-
- name: setup python .venv
2885+
- name: checkout source branch
2886+
uses: actions/checkout@v4
2887+
with:
2888+
path: source
2889+
- name: checkout target branch
2890+
uses: actions/checkout@v4
2891+
with:
2892+
path: target
2893+
repository: github.event.pull_request.base.repo.full_name
2894+
ref: github.event.pull_request.base.ref
2895+
- name: Generate target openapi specs
2896+
run: |
2897+
cd target
2898+
uv venv .venv && source .venv/bin/activate
2899+
make openapi-specs
2900+
- name: Generate source openapi-specs and compare
28872901
run: |
2888-
python -m venv .venv
2889-
source .venv/bin/activate
2890-
cd services/api-server
2891-
make install-dev
2892-
make openapi-diff.md OPENAPI_JSON_BASE_URL=https://raw.githubusercontent.com/${{ github.repository }}/refs/heads/${{ github.event.pull_request.base.ref }}/services/api-server/openapi.json
2902+
cd source
2903+
uv venv .venv && source .venv/bin/activate
2904+
make openapi-specs

0 commit comments

Comments
 (0)