refactor

Author: odeimaiz

services/static-webserver/client/source/class/osparc/data/model/Node.js

@@ -925,15 +925,20 @@ qx.Class.define("osparc.data.model.Node", {
       }
     },
 
+    __removeInputNodeByIndex: function(index) {
+      // make sue index is valid
+      if (index < 0 || index >= this.__inputNodes.length) {
+        return false;
+      }
+      // remove node connection
+      this.__inputNodes.splice(index, 1);
+      this.fireEvent("changeInputNodes");
+      return true;
+    },
+
     removeInputNode: function(inputNodeId) {
       const index = this.__inputNodes.indexOf(inputNodeId);
-      if (index > -1) {
-        // remove node connection
-        this.__inputNodes.splice(index, 1);
-        this.fireEvent("changeInputNodes");
-        return true;
-      }
-      return false;
+      this.__removeInputNodeByIndex(index);
     },
 
     isInputNode: function(inputNodeId) {
@@ -1451,6 +1456,14 @@ qx.Class.define("osparc.data.model.Node", {
             break;
           }
           case "inputNodes":
+            if (op === "add") {
+              const inputNodeId = value;
+              this.addInputNode(inputNodeId);
+            } else if (op === "remove") {
+              const index = path.split("/")[4];
+              this.__removeInputNodeByIndex(index);
+            }
+            break;
           case "inputsRequired":
             console.warn(`To be implemented: patching ${nodeProperty} is not supported yet`);
             break;

services/static-webserver/client/source/class/osparc/workbench/WorkbenchUI.js

@@ -828,39 +828,44 @@ qx.Class.define("osparc.workbench.WorkbenchUI", {
         const edgeUI = new osparc.workbench.EdgeUI(edge, edgeRepresentation);
         this.__edgesUI.push(edgeUI);
 
-        const hint = edgeUI.getHint();
-        const that = this;
+        this.__decorateEdgeUI(edgeUI);
+      }
+    },
+
+    __decorateEdgeUI: function(edgeUI) {
+      const hint = edgeUI.getHint();
+      const edgeRepresentation = edgeUI.getRepresentation();
+      const that = this;
+      [
+        edgeRepresentation.widerCurve.node,
+        edgeRepresentation.node
+      ].forEach(svgEl => {
+        svgEl.addEventListener("click", e => {
+          // this is needed to get out of the context of svg
+          that.__setSelectedItem(edgeUI.getEdgeId()); // eslint-disable-line no-underscore-dangle
+          e.stopPropagation();
+        }, this);
+
+        const topOffset = 20;
         [
-          edgeRepresentation.widerCurve.node,
-          edgeRepresentation.node
-        ].forEach(svgEl => {
-          svgEl.addEventListener("click", e => {
-            // this is needed to get out of the context of svg
-            that.__setSelectedItem(edgeUI.getEdgeId()); // eslint-disable-line no-underscore-dangle
-            e.stopPropagation();
+          "mouseover",
+          "mousemove"
+        ].forEach(ev => {
+          svgEl.addEventListener(ev, e => {
+            const leftOffset = -(parseInt(hint.getHintBounds().width/2));
+            const properties = {
+              top: e.clientY + topOffset,
+              left: e.clientX + leftOffset
+            };
+            hint.setLayoutProperties(properties);
+            if (hint.getText()) {
+              hint.show();
+            }
           }, this);
-
-          const topOffset = 20;
-          [
-            "mouseover",
-            "mousemove"
-          ].forEach(ev => {
-            svgEl.addEventListener(ev, e => {
-              const leftOffset = -(parseInt(hint.getHintBounds().width/2));
-              const properties = {
-                top: e.clientY + topOffset,
-                left: e.clientX + leftOffset
-              };
-              hint.setLayoutProperties(properties);
-              if (hint.getText()) {
-                hint.show();
-              }
-            }, this);
-          });
         });
-        edgeUI.getRepresentation().widerCurve.node.addEventListener("mouseout", () => hint.exclude(), this);
-        this.__svgLayer.addListener("mouseout", () => hint.exclude(), this);
-      }
+      });
+      edgeRepresentation.widerCurve.node.addEventListener("mouseout", () => hint.exclude(), this);
+      this.__svgLayer.addListener("mouseout", () => hint.exclude(), this);
     },
 
     __updateAllEdges: function() {