review @pcrespov

Author: matusdrobuliak66

services/web/server/src/simcore_service_webserver/chatbot/__init__.py

@@ -1,7 +0,0 @@
-# mypy: disable-error-code=truthy-function
-from ._client import ChatbotRestClient, get_chatbot_rest_client
-
-__all__ = [
-    "get_chatbot_rest_client",
-    "ChatbotRestClient",
-]

services/web/server/src/simcore_service_webserver/chatbot/_client.py

@@ -1,11 +1,5 @@
-"""Interface to communicate with Fogbugz API
-
-- Simple client to create cases in Fogbugz
-"""
-
 import logging
 from typing import Annotated, Any, Final
-from urllib.parse import urljoin
 
 import httpx
 from aiohttp import web
@@ -67,7 +61,7 @@ def __init__(self, chatbot_settings: ChatbotSettings) -> None:
 
     async def get_settings(self) -> dict[str, Any]:
         """Fetches chatbot settings"""
-        url = urljoin(f"{self._chatbot_settings.base_url}", "/v1/chat/settings")
+        url = httpx.URL(self._chatbot_settings.base_url).join("/v1/chat/settings")
 
         @_chatbot_retry()
         async def _request() -> httpx.Response:
@@ -85,7 +79,7 @@ async def _request() -> httpx.Response:
 
     async def ask_question(self, question: str) -> ChatResponse:
         """Asks a question to the chatbot"""
-        url = urljoin(self._chatbot_settings.base_url, "/v1/chat")
+        url = httpx.URL(self._chatbot_settings.base_url).join("/v1/chat")
 
         @_chatbot_retry()
         async def _request() -> httpx.Response:
@@ -146,3 +140,4 @@ async def cleanup_chatbot_client(app: web.Application) -> None:
 def get_chatbot_rest_client(app: web.Application) -> ChatbotRestClient:
     app_key: ChatbotRestClient = app[_APPKEY]
     return app_key
+    return app_key

services/web/server/src/simcore_service_webserver/chatbot/chatbot_service.py

@@ -0,0 +1,7 @@
+# mypy: disable-error-code=truthy-function
+from ._client import ChatbotRestClient, get_chatbot_rest_client
+
+__all__ = [
+    "get_chatbot_rest_client",
+    "ChatbotRestClient",
+]